Skip to content

Refine English copy on the events page - #39

Open
AnnieScigliano wants to merge 1 commit into
mainfrom
content/events-english-polish
Open

Refine English copy on the events page#39
AnnieScigliano wants to merge 1 commit into
mainfrom
content/events-english-polish

Conversation

@AnnieScigliano

Copy link
Copy Markdown
Contributor

Summary

  • make the English events introduction more accurate and idiomatic
  • refine the virtual-room, field-note, movement, and Hospital CIMA descriptions
  • preserve the existing Spanish copy unchanged

Verification

  • git diff --check
  • confirmed obsolete English phrases no longer appear
  • confirmed matching language markup counts: 57 Spanish spans and 57 English spans

Test limitation

The repository test suite could not run locally because the system Node executable fails to load libsimdutf.33.dylib. This is a local runtime dependency problem rather than a test failure.

@nicoechaniz nicoechaniz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical/content review passed. I ran the repository suite on Linux (64/64), the static build, diff-check, and verified 57 ES / 57 EN spans. The change is isolated to English copy and preserves the evergreen /eventos/ structure and Spanish text. One optional idiom tweak: “welcoming us and our proposal” could read “welcoming us and being open to our proposal”; it is not blocking. I did not merge because main publishes GitHub Pages and this review is not separate publication approval.

@nicoechaniz

Copy link
Copy Markdown
Contributor

Coordination with #40: the new evergreen catalog draft also touches eventos/index.html, so #40 is paused behind this PR. The intended order is #39 first, then rebase #40 and preserve all of this PR's history/field-note copy. The old hardcoded virtual-session paragraph is the sole edit expected to disappear because #40 replaces that entire stale block with canonical catalog rendering. I will not merge or rewrite this branch.

@nicoechaniz

Copy link
Copy Markdown
Contributor

Fresh review against current main@950330f6 after the August 11/catalog changes: the exact head 9915c3c7 still applies cleanly, remains isolated to English prose in eventos/index.html, and preserves the new event state. The composed tree passes 64/64 tests, build, and diff-check. Existing approval remains valid. I am not merging because main publishes GitHub Pages and no separate landing publication approval has been given.

@nicoechaniz

Copy link
Copy Markdown
Contributor

Revisión final contra el main actual:

  • esta PR ya quedó técnicamente aprobada sobre 9915c3c;
  • PR Align Spanish Eventos copy with Annie's English refinements #43 integró los mismos refinamientos en inglés y añadió su alineación editorial en castellano;
  • el main actual conserva todos los textos ingleses de esta PR;
  • node --test tests/registration-pages.test.js pasa 11/11, incluida Annie editorial refinements stay aligned in Spanish and English.

Conclusión: el trabajo de esta PR ya está incorporado por #43. No conviene resolver el conflicto ni mergearla otra vez; puede cerrarse como superseded por #43, preservando la autoría y este enlace como evidencia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants