fix(gensui): correct frontend dist path resolution#13
Open
wstlima wants to merge 1 commit into
Open
Conversation
GENSUI_ROOT (gensui/config.py:14) resolves to /app/gensui — the Python package directory. app.py used GENSUI_ROOT / "frontend" / "dist" to locate the built admin UI, but the Docker image places the built frontend one level up, at /app/frontend/dist (see gensui/Dockerfile:31, `COPY --from=frontend-builder /app/frontend/dist ./frontend/dist` under WORKDIR /app). Effect: frontend_dist.exists() was always False inside the container, so the `/` route and the SPA catch-all were never registered. Every request to the root or any client-side route returned FastAPI's default 404: $ curl -s http://127.0.0.1:8787/ {"detail":"Not Found"} ...despite the built files being present and intact: $ docker exec gensui ls /app/frontend/dist/index.html /app/frontend/dist/index.html Fix: try GENSUI_ROOT.parent / "frontend" / "dist" first (matches the Docker layout), falling back to the original GENSUI_ROOT / "frontend" / "dist" if that doesn't exist — preserves behavior for the local `install.sh` install path, which may lay out files differently. After fix: $ curl -s -o /dev/null -w "%{http_code}" http://127.0.0.1:8787/ 200
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
Summary
GENSUI_ROOTresolves to/app/gensui(the Python package dir), but the Docker image places the built frontend one level up at/app/frontend/distfrontend_dist.exists()was alwaysFalseinside the container, so/and the SPA catch-all routes were never registered — every request to the root returned FastAPI's default 404Reproduction (before fix)
Fix
Try
GENSUI_ROOT.parent / "frontend" / "dist"first (matches the Docker layout), falling back to the original path if that doesn't exist — preserves the localinstall.shinstall path.Test plan
curl -s -o /dev/null -w "%{http_code}" http://127.0.0.1:8787/→200index.html