fix(gensui): add missing bcrypt and pyjwt dependencies#12
Open
wstlima wants to merge 1 commit into
Open
Conversation
gensui/services/auth_service.py imports both `bcrypt` (line 8) and
`jwt` (line 9) but neither is declared in pyproject.toml. The Docker
build succeeds (no static import check at build time), but the
container crashes on startup as soon as any route imports
auth_service — which happens immediately via app.py's router
registration.
Reproduction (Docker):
cd gensui && docker compose up -d --build
docker compose logs gensui
Traceback (before fix):
File "/app/gensui/services/auth_service.py", line 8, in <module>
import bcrypt
ModuleNotFoundError: No module named 'bcrypt'
After adding bcrypt, the next import fails the same way:
File "/app/gensui/services/auth_service.py", line 9, in <module>
import jwt
ModuleNotFoundError: No module named 'jwt'
Fix: add both packages to pyproject.toml dependencies. Verified the
full gensui/ import surface has no other undeclared third-party
imports:
find gensui -name "*.py" | xargs grep -hE "^import |^from " \
| sed -E 's/^(import|from) ([a-zA-Z0-9_]+).*/\2/' | sort -u
After fix: container starts cleanly, GET /api/gensui/health returns
{"status":"ok","service":"gensui","version":"0.1.0"}.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Summary
gensui/services/auth_service.pyimportsbcryptandjwtbut neither is declared inpyproject.tomlauth_serviceReproduction (before fix)
Test plan
gensui/via grep of all import statementsGET /api/gensui/healthreturns{"status":"ok",...}