feat(oracle): default price updates to Lazer - #164
Conversation
|
operate.md full-sweep review — PR #164 ( Cutover verified: no functional Findings:
Recommendation: hold merge — update the branch (BEHIND), obtain 2 approvals, and confirm the testnet Lazer behavior above. No prod-mainnet correctness blocker in the code itself. |
Every method taking priceUpdateCoinTypes accepts lazerUpdateBytes, and updatePrices/updateAllPrices/updatePricesLazer take it as a third arg; when present the SDK makes no request to AlphaLend's proxy, so a CORS-blocked browser or an API outage doesn't prevent transacting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
@claude review |
operate.md review —
|
jangid
left a comment
There was a problem hiding this comment.
operate.md: clean — CI green. My 2026-07-23 finding (testnet/devnet unconditionally routed through Lazer) is resolved: I enumerated every price-refresh call site in client.ts (:584, :697, :855, :1179, :1445, :1604) and all six are network-guarded with setPrices() on the non-mainnet branch, and updatePrices/updateAllPrices have no other callers. Also verified the fail-closed dependency is satisfied — api.alphalend.xyz/lazer/prices and /lazer/update both return 200 with live data in production. Remaining items are 🟢 cosmetic (the stale useLazer comment at devConstants.ts:73-75). Approvals: 2/2 — merge-ready.
Summary
useLazerclient option/lazer/updatepathlazerUpdateByteson every params interface that takespriceUpdateCoinTypes(plusFlashRepayParams), or as a third argument toupdatePrices/updateAllPrices/updatePricesLazer; with it supplied, transaction building makes no request to the proxy, so a CORS-blocked browser or an API outage doesn't prevent transactingValidation
npm run buildnpm test(58 tests)npx eslint 'src/**/*.ts' '__tests__/**/*.ts'Scope
No dependency or lockfile changes. API changes are additive only (optional param field + optional trailing argument).