Use @naviprotocol/lending v2 for flash loans - #162
Merged
Conversation
Zorag44
reviewed
Jul 22, 2026
Zorag44
approved these changes
Jul 22, 2026
jangid
approved these changes
Jul 23, 2026
jangid
left a comment
jangid
left a comment
Contributor
There was a problem hiding this comment.
operate.md full-sweep: clean. Pure dependency swap to @naviprotocol/lending v2 for flash loans — buildFlashRepayTransaction borrow/repay/fee logic untouched; verified (read-only, from the published 2.0.3 tarball) that real signatures match the shim and the removed vendored helpers exactly, same Move targets (flash_loan_with_ctx/_v2/flash_repay_with_ctx), borrow/repay stay balanced. Dependency is exact-pinned 2.0.3 with NO lifecycle scripts (no supply-chain exposure of the #85 class); new transitives are benign + integrity-pinned. CI green. Prior review finding (shim type-drift) resolved by the exact pin. Approvals: 2/2 — meets threshold; merge-ready pending your merge decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the vendored Navi flash-loan helpers (
src/vendor/naviFlashloan.ts) with@naviprotocol/lending@^2.0.3as a runtime dependency (v2 is@mysten/suiv2-native and import-safe). Adds a local.d.tsshim since NAVI v2's split declarations don't resolve undermoduleResolution: NodeNext.