refactor: remove dead StartMenuMonitor and correct OVERVIEW's fallback description#66
Conversation
…k description StartMenuMonitor had zero compile-time references and its HostProcessNames set is the exact false-positive pattern PR #64 removed from SystemStartMenu. The no-bridge scenario it was documented to cover is already handled by the always-installed managed hooks (StartClickHook + WinKeyHook), so OVERVIEW.md now describes that real mechanism instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughDocumentation in docs/OVERVIEW.md was reworded to describe ChangesDocumentation wording update
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
src/MenYou/Platform/Windows/StartMenuMonitor.cs(271 lines, zero compile-time references — the only mention outside the file was indocs/OVERVIEW.md).docs/OVERVIEW.md: it claimed MenYou "falls back to a managed WinEvent monitor (StartMenuMonitor)" when the bridge DLL is absent — no code path ever did this. The activation bullet now describes the real dual mechanism (WinKeyHookout-of-process + native bridge in-process) and the actual no-MSVC behavior: injection quietly no-ops and the managed hooks carry the interception alone.Why delete rather than wire it up
StartMenuMonitoris already served by the always-installed managed hooks (StartClickHook+WinKeyHook) — there is no functional gap for it to fill.HostProcessNamesset (StartMenuExperienceHost,SearchHost,SearchApp,ShellExperienceHost) that fix(start): stop the native Start menu leaking on some taskbar clicks #64 identified as the cause of the Search/Action-Center false positives. Reusing it would reintroduce that bug.Verification
dotnet build src/MenYou/MenYou.csproj— success, 0 warnings, 0 errors.🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Bug Fixes