Skip to content

refactor: remove dead StartMenuMonitor and correct OVERVIEW's fallback description#66

Merged
Alpaq92 merged 1 commit into
mainfrom
claude/priceless-rhodes-79cbcb
Jul 9, 2026
Merged

refactor: remove dead StartMenuMonitor and correct OVERVIEW's fallback description#66
Alpaq92 merged 1 commit into
mainfrom
claude/priceless-rhodes-79cbcb

Conversation

@Alpaq92

@Alpaq92 Alpaq92 commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Delete src/MenYou/Platform/Windows/StartMenuMonitor.cs (271 lines, zero compile-time references — the only mention outside the file was in docs/OVERVIEW.md).
  • Fix docs/OVERVIEW.md: it claimed MenYou "falls back to a managed WinEvent monitor (StartMenuMonitor)" when the bridge DLL is absent — no code path ever did this. The activation bullet now describes the real dual mechanism (WinKeyHook out-of-process + native bridge in-process) and the actual no-MSVC behavior: injection quietly no-ops and the managed hooks carry the interception alone.

Why delete rather than wire it up

Verification

dotnet build src/MenYou/MenYou.csproj — success, 0 warnings, 0 errors.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Updated build and activation notes to reflect the current Win-key handling behavior and fallback behavior when native build support is unavailable.
  • Bug Fixes

    • Simplified Start-menu interception flow so lone Win-tap handling relies on the managed keyboard hooks, improving consistency on supported Windows versions.

…k description

StartMenuMonitor had zero compile-time references and its HostProcessNames
set is the exact false-positive pattern PR #64 removed from SystemStartMenu.
The no-bridge scenario it was documented to cover is already handled by the
always-installed managed hooks (StartClickHook + WinKeyHook), so OVERVIEW.md
now describes that real mechanism instead.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by .github/workflows/auto-approve-chore.yml — non-feature PR from trusted author.

@Alpaq92 Alpaq92 enabled auto-merge (squash) July 9, 2026 10:53
@Alpaq92 Alpaq92 disabled auto-merge July 9, 2026 10:53
@Alpaq92 Alpaq92 merged commit fdea126 into main Jul 9, 2026
8 of 9 checks passed
@Alpaq92 Alpaq92 deleted the claude/priceless-rhodes-79cbcb branch July 9, 2026 10:54
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1b60adf3-5050-43b4-a55a-c921e17b34ba

📥 Commits

Reviewing files that changed from the base of the PR and between d15126b and 928d8e7.

📒 Files selected for processing (2)
  • docs/OVERVIEW.md
  • src/MenYou/Platform/Windows/StartMenuMonitor.cs

Walkthrough

Documentation in docs/OVERVIEW.md was reworded to describe WinKeyHook handling lone Win-tap interception and managed hooks alone as the fallback when the native bridge is unavailable, replacing prior references to a StartMenuMonitor component that has been removed from the codebase.

Changes

Documentation wording update

Layer / File(s) Summary
Activation and build/run wording
docs/OVERVIEW.md
Reworded the Win-tap interception description to reference WinKeyHook and the native bridge, and updated the MSVC-missing fallback text from referencing StartMenuMonitor to describing reliance on managed hooks alone, in both the Activation and Build & run sections.
Removal of StartMenuMonitor implementation
src/MenYou/Platform/Windows/StartMenuMonitor.cs
Removed the StartMenuMonitor class along with its WinEvent hook installation, Start-menu dismissal logic, and Intercepted event, eliminating the component referenced by the prior documentation.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/priceless-rhodes-79cbcb

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant