fix(semver): a BREAKING CHANGE footer must be a footer, not prose - #11
Merged
Conversation
version next reported major for a release where nothing broke. The cause is self-referential: the commit that documented this very mechanism contains the phrase "BREAKING CHANGE footer" while explaining it, and the check searched the whole body for the phrase. Conventional Commits defines it as a footer: line-anchored, with a colon. Now matched with (?mi)^BREAKING[ -]CHANGE: so discussing a breaking change is no longer the same as making one. The regression test uses the exact prose that caused it, and asserts that indented text, mid-line mentions and a colon-less phrase are all not footers, while BREAKING-CHANGE: and lowercase still are. Effect: the pending release goes from v1.0.0 to v0.2.0, which is what actually happened. Assisted-by: Claude:claude-opus-4.7 kiro-cli gofmt go-vet go-test golangci-lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version next reported major for a release where nothing broke. The cause is self-referential: the commit that documented this very mechanism contains the phrase "BREAKING CHANGE footer" while explaining it, and the check searched the whole body for the phrase.
Conventional Commits defines it as a footer: line-anchored, with a colon. Now matched with (?mi)^BREAKING[ -]CHANGE: so discussing a breaking change is no longer the same as making one.
The regression test uses the exact prose that caused it, and asserts that indented text, mid-line mentions and a colon-less phrase are all not footers, while BREAKING-CHANGE: and lowercase still are.
Effect: the pending release goes from v1.0.0 to v0.2.0, which is what actually happened.
Assisted-by: Claude:claude-opus-4.7 kiro-cli gofmt go-vet go-test golangci-lint