Develop#1
Open
AlinaMatuschak wants to merge 17 commits into
Open
Conversation
ArtemLav
approved these changes
Sep 11, 2020
Comment on lines
+1
to
+2
| @import "./../utils/vars"; | ||
|
|
There was a problem hiding this comment.
you're importing your vars everywhere, just import it to your main scss file instead.
Comment on lines
+108
to
+112
| &:checked ~ .header__navigation { | ||
| display: block; | ||
| transform: translateX(100%); | ||
| animation: appear 1s ease-out forwards; | ||
| } |
Comment on lines
+19
to
+25
| &__link { | ||
| padding: $link-padding; | ||
| color: $text-light; | ||
| text-transform: uppercase; | ||
| @include active; | ||
| @include hover(opacity, 0.8); | ||
| } |
There was a problem hiding this comment.
i don't know whether it is important or not, but mockup has 1 active link
Comment on lines
+104
to
+106
| &__menu-input { | ||
| display: none; | ||
| width: 0; |
There was a problem hiding this comment.
if you set width of 0, do you still need to set display: none?
Comment on lines
+294
to
+299
| <label for="textarea"> | ||
| <textarea | ||
| id="textarea" | ||
| name="textarea" | ||
| placeholder="Message" | ||
| class="form__input form__input--big" |
Comment on lines
+45
to
+50
| &__title { | ||
| position: relative; | ||
| max-width: 370px; | ||
| margin-bottom: 85px; | ||
| font-size: 60px; | ||
|
|
There was a problem hiding this comment.
on small devices header could not contain this title
screenshot
Comment on lines
+14
to
+18
| &__contacts { | ||
| @include flexCentering; | ||
| margin-bottom: 315px; | ||
| z-index: 2; | ||
| } |
|
В качестве ховера для кнопки рекомендую изменять background-color |
danheim
approved these changes
Sep 15, 2020
|
|
||
| <main class="main"> | ||
| <section class="main__about-us about-us" id="about-us"> | ||
| <h2 class="about-us__slogan">Miami best <br>Real estate <span class="about-us__emphasis">here</span></h2> |
There was a problem hiding this comment.
Suggested change
| <h2 class="about-us__slogan">Miami best <br>Real estate <span class="about-us__emphasis">here</span></h2> | |
| <h2 class="about-us__slogan"> | |
| Miami best <br>Real estate | |
| <span class="about-us__emphasis">here</span> | |
| </h2> |
|
|
||
| <article class="gallery__article"> | ||
| <div class="gallery__line gallery__line--first"> | ||
| <a href="https://www.google.com/maps/place/%D0%9D%D0%BE%D1%80%D1%82-%D0%9C%D0%B0%D1%8F%D0%BC%D1%96-%D0%91%D1%96%D1%87,+%D0%A4%D0%BB%D0%BE%D1%80%D0%B8%D0%B4%D0%B0+33162,+%D0%A1%D0%BF%D0%BE%D0%BB%D1%83%D1%87%D0%B5%D0%BD%D1%96+%D0%A8%D1%82%D0%B0%D1%82%D0%B8+%D0%90%D0%BC%D0%B5%D1%80%D0%B8%D0%BA%D0%B8/@25.9289247,-80.2148991,13z/data=!3m1!4b1!4m5!3m4!1s0x88d9addb1b652001:0x525bd42381a2a4cf!8m2!3d25.9260794!4d-80.1819268"> |
There was a problem hiding this comment.
make it easy to read for now
Suggested change
| <a href="https://www.google.com/maps/place/%D0%9D%D0%BE%D1%80%D1%82-%D0%9C%D0%B0%D1%8F%D0%BC%D1%96-%D0%91%D1%96%D1%87,+%D0%A4%D0%BB%D0%BE%D1%80%D0%B8%D0%B4%D0%B0+33162,+%D0%A1%D0%BF%D0%BE%D0%BB%D1%83%D1%87%D0%B5%D0%BD%D1%96+%D0%A8%D1%82%D0%B0%D1%82%D0%B8+%D0%90%D0%BC%D0%B5%D1%80%D0%B8%D0%BA%D0%B8/@25.9289247,-80.2148991,13z/data=!3m1!4b1!4m5!3m4!1s0x88d9addb1b652001:0x525bd42381a2a4cf!8m2!3d25.9260794!4d-80.1819268"> | |
| <a href="https://google.com"> |
| <div class="consult__content"> | ||
| <div class="consult__inf"> | ||
| <h3 class="consult__foreword">How long have you do yourself a gift?</h3> | ||
| <p class="consult__text">The procedural change mezzo forte starts izoritmichesky pickup at these moments stop LA Mazel and VA Tsukkerman in his "Analysis of musical works." Pointillism, which originated in the music of the early twentieth century, microforms, found a distant historical.</p> |
There was a problem hiding this comment.
Suggested change
| <p class="consult__text">The procedural change mezzo forte starts izoritmichesky pickup at these moments stop LA Mazel and VA Tsukkerman in his "Analysis of musical works." Pointillism, which originated in the music of the early twentieth century, microforms, found a distant historical.</p> | |
| <p class="consult__text"> | |
| The procedural change mezzo forte starts izoritmichesky pickup at these moments stop LA Mazel and VA Tsukkerman in his "Analysis of musical works." Pointillism, which originated in the music of the early twentieth century, microforms, found a distant historical. | |
| </p> |
| > | ||
| <h3 class="testimonials__name">Scarlett Hawkins</h3> | ||
| <span class="testimonials__position">Senior Vice President</span> | ||
| <p class="testimonials__comment">My soul is illuminated by an unearthly joy, as these beautiful spring morning, which I enjoy with all my heart</p> |
There was a problem hiding this comment.
Suggested change
| <p class="testimonials__comment">My soul is illuminated by an unearthly joy, as these beautiful spring morning, which I enjoy with all my heart</p> | |
| <p class="testimonials__comment"> | |
| My soul is illuminated by an unearthly joy, as these beautiful spring morning, which I enjoy with all my heart | |
| </p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK