Skip to content

Fix: Add mounted checks to prevent widget lifecycle errors #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karolinaoparczyk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Add mounted checks to prevent widget lifecycle errors #151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
134043c
Add mounted checks before setState calls to prevent runtime errors
karolinaoparczyk Jul 22, 2025
e90805a
Enhance mounted checks with early returns
karolinaoparczyk Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions lib/src/view/flutter_slider_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,8 +435,9 @@ class _FlutterSliderState extends State<FlutterSlider>
_arrangeHandlersPosition();

_drawHatchMark();

setState(() {});
if (mounted) {
setState(() {});
}
});
}

Expand Down Expand Up @@ -911,8 +912,9 @@ class _FlutterSliderState extends State<FlutterSlider>
{double lockedHandlersDragOffset = 0,
double tappedPositionWithPadding = 0,
bool selectedByTap = false}) {
if (widget.disabled || (widget.handler != null && widget.handler!.disabled))
return;
if (!mounted ||
widget.disabled ||
(widget.handler != null && widget.handler!.disabled)) return;

_handlersDistance = widget.lockDistance ?? _upperValue! - _lowerValue!;

Expand Down Expand Up @@ -1042,6 +1044,7 @@ class _FlutterSliderState extends State<FlutterSlider>
if (widget.lockHandlers || lockedHandlersDragOffset > 0) {
_lockedHandlers('leftHandler');
}

setState(() {});

if (selectedByTap) {
Expand Down Expand Up @@ -1164,7 +1167,8 @@ class _FlutterSliderState extends State<FlutterSlider>

void _rightHandlerMove(PointerEvent pointer,
{double tappedPositionWithPadding = 0, bool selectedByTap = false}) {
if (widget.disabled ||
if (!mounted ||
widget.disabled ||
(widget.rightHandler != null && widget.rightHandler!.disabled)) return;

_handlersDistance = widget.lockDistance ?? _upperValue! - _lowerValue!;
Expand Down Expand Up @@ -1477,12 +1481,15 @@ class _FlutterSliderState extends State<FlutterSlider>
),
feedback: Container()),
onPointerMove: (_) {
if (!mounted) return;

__dragging = true;

_leftHandlerMove(_);
},
onPointerDown: (_) {
if (widget.disabled ||
if (!mounted ||
widget.disabled ||
(widget.handler != null && widget.handler!.disabled)) return;

_renderBoxInitialization();
Expand All @@ -1508,6 +1515,8 @@ class _FlutterSliderState extends State<FlutterSlider>
_callbacks('onDragStarted', 0);
},
onPointerUp: (_) {
if (!mounted) return;

__dragging = false;

_adjustLeftHandlerPosition();
Expand Down Expand Up @@ -1559,6 +1568,8 @@ class _FlutterSliderState extends State<FlutterSlider>
}

void _hideTooltips() {
if (!mounted) return;

if (!_tooltipData.alwaysShowTooltip!) {
_leftTooltipOpacity = 0;
_rightTooltipOpacity = 0;
Expand Down Expand Up @@ -1602,6 +1613,8 @@ class _FlutterSliderState extends State<FlutterSlider>
// color: Colors.blue.withOpacity(0.7),
)),
onPointerMove: (_) {
if (!mounted) return;

__dragging = true;

if (!_tooltipData.disabled! &&
Expand All @@ -1611,6 +1624,7 @@ class _FlutterSliderState extends State<FlutterSlider>
_rightHandlerMove(_);
},
onPointerDown: (_) {
if (!mounted) return;
if (widget.disabled ||
(widget.rightHandler != null && widget.rightHandler!.disabled))
return;
Expand Down Expand Up @@ -1640,6 +1654,8 @@ class _FlutterSliderState extends State<FlutterSlider>
_callbacks('onDragStarted', 1);
},
onPointerUp: (_) {
if (!mounted) return;

__dragging = false;

_adjustRightHandlerPosition();
Expand Down Expand Up @@ -1699,6 +1715,8 @@ class _FlutterSliderState extends State<FlutterSlider>

void _stopHandlerAnimation(
{Animation? animation, AnimationController? controller}) {
if (!mounted) return;

if (widget.handlerAnimation.reverseCurve != null) {
if (animation!.isCompleted)
controller!.reverse();
Expand Down Expand Up @@ -1728,6 +1746,8 @@ class _FlutterSliderState extends State<FlutterSlider>
opacity: 0,
child: Listener(
onPointerUp: (_) {
if (!mounted) return;

if (widget.selectByTap && !__dragging) {
tappedPositionWithPadding = _distance();
if (_distanceFromLeftHandler! < _distanceFromRightHandler!) {
Expand Down Expand Up @@ -1773,6 +1793,8 @@ class _FlutterSliderState extends State<FlutterSlider>
setState(() {});
},
onPointerMove: (_) {
if (!mounted) return;

__dragging = true;

if (_slidingByActiveTrackBar) {
Expand Down Expand Up @@ -1815,6 +1837,8 @@ class _FlutterSliderState extends State<FlutterSlider>
}
},
onPointerDown: (_) {
if (!mounted) return;

_leftTapAndSlide = false;
_rightTapAndSlide = false;
_slidingByActiveTrackBar = false;
Expand Down