Add Cloudflare detection step. - #3
Open
lerdem wants to merge 2 commits into
Open
Conversation
|
|
||
| if has_cloudflare_issues: | ||
| pretty_print("!", "Failed because of Cloudflare protection!") | ||
| raise ValueError(title.text) |
Owner
There was a problem hiding this comment.
This will for sure trigger the exception call at the end of the loop
Author
There was a problem hiding this comment.
Yes, it will trigger the exception. But all program flow is wrapped with try... except (source) block, so that exception will be handled properly.
What do you think?
|
|
||
| r = fetch("https://liveuamap.com/") | ||
| html = BeautifulSoup(r, "html.parser") | ||
| _check_cloudflare(html) |
Owner
There was a problem hiding this comment.
I recommend having this spit a variable instead, and then something like "If True is returned, throw error and wait time before doing a continue back to start"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Cloudflare detection check. For more obvious error message.