Thanks and heres where I took this#1
Open
othrayte wants to merge 8 commits into
Open
Conversation
BLE connections to the Powerpal can drop or return garbage data, especially while BlueZ is still settling after bonding. Without retries and validation the script silently produces wrong output or crashes on the first transient error.
Manually finding the MAC address is a friction point for new users. Scanning by device name removes it entirely in the common case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thankyou for doing the hard work of finding a way to automate getting the auth key!
I had some issues running it on Fedora, and ended up making my own fork with not just my issues fixed but also adding more robust retries and error handling, automated detection of the powerpal device, and a refined user experience.
Just wanted to let you know and see your thoughts, given you don't have a license listed I also felt it would be best to check you're ok with me forking and making my own version.