fix: pin macOS installer server endpoint - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
v2.6.0-macos.1 安装器结束时打印的服务启动命令可能继承调用环境中的 CAPSWRITER_SERVER_BIND 和 CAPSWRITER_SERVER_PORT,导致无认证服务意外监听局域网,或与 Finder 启动的客户端端口不一致。
改动
验证
风险与后续
合并后才会创建 v2.6.0-macos.2 tag 和 prerelease;tag、安装脚本、SHA256SUMS 和公开下载必须逐项回读一致。旧 v2.6.0-macos.1 保持不变。