Sanitize buildah image tag derived from build-context basename#25
Merged
Conversation
waypoint build derived the buildah tag as 'waypoint_<basename>:<ts>' without sanitizing the context directory's basename. A basename ending in a separator (e.g. tempfile.mkdtemp dirs like 'img3_4l96kk1_') or containing uppercase/other invalid characters produced a reference buildah rejects with "invalid reference format", aborting the build. Sanitize the basename via imageRefComponent(): lowercase, collapse runs of disallowed characters to '-', trim trailing separators, and fall back to a short sha1 hash when nothing usable remains, so the result always matches the Docker/buildah name-component grammar. Add build_test.go covering a basename that ends in '_' and contains an uppercase letter, plus the hash-fallback case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waypoint build derived the buildah tag as 'waypoint_:' without sanitizing the context directory's basename. A basename ending in a separator (e.g. tempfile.mkdtemp dirs like 'img3_4l96kk1_') or containing uppercase/other invalid characters produced a reference buildah rejects with "invalid reference format", aborting the build.
Sanitize the basename via imageRefComponent(): lowercase, collapse runs of disallowed characters to '-', trim trailing separators, and fall back to a short sha1 hash when nothing usable remains, so the result always matches the Docker/buildah name-component grammar.
Add build_test.go covering a basename that ends in '_' and contains an uppercase letter, plus the hash-fallback case.