feat(cli): add --quiet flag and dual-register --verbose on check subcommand - #144
Merged
Merged
Conversation
…ommand Implement three-tier verbosity control (quiet/default/verbose) for the check command. Add -q/--quiet to both the app callback and check subcommand, dual-register --verbose on check so it works in both positions, and gate all stderr metadata behind quiet checks. - Add -q/--quiet flag to app callback and check subcommand - Dual-register --verbose on check with OR-resolution from both positions - Gate summary line, per-check timing, verbose header, and file count - Quiet wins over verbose when both specified - Add quiet parameter to _run_griffe for forward compatibility - Add 15 new tests, update 2 existing tests (860 total)
…mand Move verbose/quiet dual-resolution before _discover_and_handle call so subcommand-level flags take effect for file count output. Strengthen AC1/AC2 verbose tests to assert per-check timing and file count.
There was a problem hiding this comment.
Pull request overview
This PR adds three-tier verbosity control (quiet/default/verbose) to the docvet check command by introducing a --quiet/-q flag and by making --verbose work both before and after the subcommand name via dual-registration and OR-resolution.
Changes:
- Add
-q/--quietto the app callback and tocheck, and resolve verbosity flags across positions (docvet -q checkanddocvet check -q). - Gate non-finding stderr metadata (verbose header, file count, per-check timing, summary) behind
quiet(quiet wins over verbose). - Add/update unit tests to cover verbose/quiet combinations and ensure
_run_griffereceives the newquietkwarg.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/docvet/cli.py |
Implements --quiet, dual-registers --verbose on check, resolves flags into ctx.obj, and gates stderr metadata accordingly. |
tests/unit/test_cli.py |
Updates existing assertions for _run_griffe(…, quiet=…) and adds new tests for quiet/verbose behavior and help output. |
_bmad-output/implementation-artifacts/sprint-status.yaml |
Marks Story 21.3 as done. |
_bmad-output/implementation-artifacts/21-3-verbose-and-quiet-flag-redesign.md |
Adds the completed implementation artifact and AC-to-test mapping for Story 21.3. |
Alberto-Codes
added a commit
that referenced
this pull request
Feb 26, 2026
🤖 I have created a release *beep* *boop* --- ## [1.5.0](v1.4.0...v1.5.0) (2026-02-26) ### Features * **cli:** add --quiet flag and dual-register --verbose on check subcommand ([#144](#144)) ([206ab22](206ab22)) * **cli:** add --verbose and --quiet flags to individual subcommands ([#145](#145)) ([ba1bbd5](ba1bbd5)) * **cli:** replace Completed-in with Vetted summary line ([#141](#141)) ([18db009](18db009)) * **cli:** replace Completed-in with Vetted summary line on check ([18db009](18db009)) * **config:** suppress overlap warnings for default warn-on values ([#143](#143)) ([384a44a](384a44a)) ### Bug Fixes * **cli:** correct --quiet flag docs and harden griffe quiet test ([#146](#146)) ([bf1ca08](bf1ca08)) * **cli:** resolve verbose/quiet dual-resolution ordering in check ([206ab22](206ab22)) * **cli:** suppress verbose header for single-check subcommands ([ba1bbd5](ba1bbd5)) * **config:** update overlap warning docs and strengthen AC3 test ([384a44a](384a44a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three-tier verbosity control (quiet/default/verbose) to the
checksubcommand. Previously,--verboseonly worked before the subcommand name and there was no way to suppress non-finding output.-q/--quietflag to app callback andchecksubcommand with OR-resolution across positions--verboseoncheckso bothdocvet --verbose checkanddocvet check --verbosework identicallyquietparameter to_run_griffefor forward compatibility with Story 21.4_discover_and_handlesees resolved flags (code review finding)Test:
uv run pytestCloses #144
fix(cli): resolve verbose/quiet dual-resolution ordering in check command
PR Review
Checklist
uv run pytest)uv run ruff check .)uv run ty check)!in title andBREAKING CHANGE:in bodyReview Focus
check()— verbose/quiet flags now resolve before_discover_and_handleso subcommand-level flags affect file count outputRelated