Repository navigation
BE-49: Reconcile Soroban escrow state with payment records - #832
Merged
Qoder-Voidd merged 3 commits intoOct 25, 2026
Merged
Conversation
…s (BE-49) Add normalized pending/confirmed/failed/timed_out escrow outcomes, treat transient RPC failures as retryable and non-final, and persist escrow status on Payment. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #634
final/retryableflags.reconcileEscrowtreats transient RPC failures as retryable pending, never final settlement.escrowStatus/escrowReconciledAtcolumns toPayment.soroban_release_stub_/soroban_refund_stub_).Verification (Node 20):
jest soroban-escrow.provider.spec.ts: 11/11 pass.jest src/paymentsoverall: other suites fail on pre-existing syntax/duplicate-identifier errors elsewhere in the repo (auth.service.ts, bookings.service.ts, refund-payment.provider.ts); not caused by this PR.tscfails only on those same pre-existing files; no errors in the files changed here.Scope note: the issue limits changes to three files, so
reconcileEscrowis not yet wired intohandle-webhook.provider.tsand no migration is added (migrations dir has no schema-sync convention for payments). Follow-up needed for both.🤖 Generated with Claude Code