Repository navigation
fix: BE-23 - Prevent self-demotion of the last super-admin - #830
Merged
Qoder-Voidd merged 1 commit intoOct 23, 2026
Merged
Qoder-Voidd merged 1 commit into
Qoder-Voidd merged 1 commit into
Conversation
- Guard role demotion from SUPER_ADMIN to non-SUPER_ADMIN in UsersService.updateUser by counting super-admins and blocking when only one remains. - Block membership status changes that would deactivate/suspend the last super-admin via UsersService.updateMemberStatus. - Enforce the same guard directly in UpdateMemberStatusProvider as a defensive check. Closes Akazajan#645
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard administrative role changes against removing the final super-admin account.
Changes
Acceptance
Closes #645