Repository navigation
feat(bookings): add idempotency guard to booking creation (BE-28) - #829
Merged
Qoder-Voidd merged 1 commit intoOct 20, 2026
Merged
Qoder-Voidd merged 1 commit into
Qoder-Voidd merged 1 commit into
Conversation
- Add UseInterceptors to @nestjs/common imports in bookings controller - Remove duplicate CreateRecurringBookingDto import (modules/bookings path) - Apply @UseInterceptors(IdempotencyGuard) to POST /recurring endpoint - Fix IdempotencyKey unique index to include endpoint column The unique index was [key, userId] but the guard scopes reservations by [key, userId, endpoint]. Without endpoint in the index, the same key on two different endpoints would hit a spurious unique constraint violation. A migration is required to drop the old index and create the new one.
|
@Lazaruster Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #598
The unique index was [key, userId] but the guard scopes reservations by [key, userId, endpoint]. Without endpoint in the index, the same key on two different endpoints would hit a spurious unique constraint violation. A migration is required to drop the old index and create the new one.