Skip to content

feat: real step processing times + BATCH_DELETED audit trail with orphaned row dimming - #129

Merged
g9shubh merged 5 commits into
mainfrom
feat/real-step-timing-batch-delete-audit
Jul 24, 2026
Merged

feat: real step processing times + BATCH_DELETED audit trail with orphaned row dimming#129
g9shubh merged 5 commits into
mainfrom
feat/real-step-timing-batch-delete-audit

Conversation

@Akash29g

Copy link
Copy Markdown
Owner

What

Two features in one branch:

1 — Real Step Processing Time Percentiles

  • AnalyticsService.GetStepPercentilesAsync: replaced hardcoded 120s with real
    query over FileStepHistory.StartedAt / CompletedAt
  • ExtractionWorker: tracks 3 distinct timed phases (Validate, Extract, Load)
    with individual FileStepHistory entries replacing the single catch-all entry
  • Fixed return type IReadOnlyList<>List<> to match IAnalyticsService
  • Fixed test: Sut(files) instead of undefined service variable

2 — BATCH_DELETED Audit Trail + UI

  • UploadService.DeleteBatchAsync: writes a BATCH_DELETED ActivityLog
    entry (same DB transaction as the delete) capturing OldState, actor, timestamp
  • ActivityLogComponent: BATCH_DELETED rows show strikethrough + 🗑️ badge
  • DataTableComponent: new optional rowClass input for per-row CSS classes
  • File rows whose parent batch was deleted (batch_id == null) are automatically
    dimmed (opacity: 0.4) — no extra API call needed

Testing

  • Deleted a batch → activity log shows BATCH_DELETED row + all file rows grayed
  • Uploaded files → Processing Time table shows real Validate / Extract / Load times
  • All CI checks passing

@Akash29g
Akash29g requested a review from sumitgupta-cse July 24, 2026 09:51
@Akash29g
Akash29g requested a review from g9shubh as a code owner July 24, 2026 09:51
@g9shubh
g9shubh merged commit 075e153 into main Jul 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants