fix: replace hardcoded 120s step percentiles with real FileStepHistory timing - #128
Closed
Akash29g wants to merge 3 commits into
Closed
fix: replace hardcoded 120s step percentiles with real FileStepHistory timing#128Akash29g wants to merge 3 commits into
Akash29g wants to merge 3 commits into
Conversation
…ned service variable
…Async for mock compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AnalyticsService.GetStepPercentilesAsyncwas returning hardcoded 120s for allsteps — a leftover from seeded data where timestamps were artificially 120s apart
ExtractionWorkeronly recorded oneFileStepHistoryentry (Extract) coveringthe entire process with no per-phase timing
Changes
DocAnalytics.Service/Analytics/AnalyticsService.csStepPercentileDtolist with a real DB queryFileRecord(tenant/site global query filter preserved)→
FileStepHistorywhereStatus == "Success"and both timestamps presentIReadOnlyList<>→List<>to matchIAnalyticsServiceDocAnalytics.Api/BackgroundServices/ExtractionWorker.csvalidateStart,extractStart,loadStartExtractstep history entry with 3 separate timed entries:Validate— GuardDuty poll + magic-byte check durationExtract— BedrockExtractAsynccall durationLoad— DB persistence durationExtract / Processingmarker (for realtime SignalR updates) unchangedWhy
Processing Time by Step table was showing 120s for all steps even after seeded
data was cleared. Real uploads now populate with actual measured durations.
Testing
file_step_historyrows from RDS