feat: deep-link entity names in activity log and error list to batch/file detail pages - #125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Batch 335ccce0,invoice_Adam.pdf) is now aclickable link. Batch rows navigate to
/batches/:id; File rows navigate to/batches/:batchId/files/:fileId.directly to the file's step-history detail page.
Why
Entity names in both pages were static text. Ops teams had to manually find the
batch/file separately — now one click takes them straight to the drill-down.
Backend changes
ActivityLogDtos.cs— addedEntityId(Guid) +BatchId(nullable Guid) toActivityLogItemDto; changedclass→record(required forwithexpression).ActivityLogService.cs— after fetching paged results, does a second targeted queryon
_db.Filesto resolveTransactionIdfor File-type entries and populateBatchId.Guard
_db.Files is not nullhandles MockDb test contexts.ErrorDtos.cs— addedBatchId(nullable Guid) toErrorListItemDto;class→record.ErrorService.cs— same batch-lookup pattern as activity log.Frontend changes
activity-log.models.ts— addedentity_id+batch_idfields.activity-log.component.ts— injectedRouter+SiteContextService; addednavigateTo()andisNavigable()methods.activity-log.component.html— entity column uses<button class="entity-link">when navigable, static text otherwise.
activity-log.component.css— link button styles.errors/.Testing
Checklist
_db.Files is not null)