Skip to content

Fix protobuf-spi-impl configuration - #33

Merged
AkaZver merged 1 commit into
masterfrom
feature/fix-protobuf-config
Jul 29, 2026
Merged

Fix protobuf-spi-impl configuration#33
AkaZver merged 1 commit into
masterfrom
feature/fix-protobuf-config

Conversation

@AkaZver

@AkaZver AkaZver commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

Fix incorrect configuration for \protobuf-spi-impl\ dependency. According to the entur/mapstruct-spi-protobuf documentation, this is an annotation processor SPI and should be added to \�nnotationProcessor\ configuration, not \implementation.

Changes

Fixed Configuration

Before:

  • \protobuf-spi-impl\ was added to \implementation\ configuration
  • Would not work correctly with Kotlin/kapt

After:

  • \protobuf-spi-impl\ is added to \�nnotationProcessor\ configuration
  • Properly supports Kotlin via \processorConfig\ parameter (uses \kapt\ when Kotlin is detected)

Files Changed

  • \AdditionalDependency.java\ - Changed configuration from \implementation\ to \�nnotationProcessor\
  • \DependencyManager.java\ - Use \processorConfig\ parameter for Kotlin support
  • \README.md\ - Updated documentation table to reflect correct configuration
  • \DependencyTest.java\ - Updated tests to verify dependency is in \�nnotationProcessor\

Testing

All tests pass successfully:

  • Both Protobuf tests verify \protobuf-spi-impl\ is in \�nnotationProcessor\
  • Kotlin tests continue to work correctly with the updated configuration

@AkaZver AkaZver self-assigned this Jul 29, 2026
@AkaZver AkaZver added the bug Something isn't working label Jul 29, 2026
@sonarqubecloud

Copy link
Copy Markdown

@AkaZver
AkaZver merged commit cd9961a into master Jul 29, 2026
7 checks passed
@AkaZver
AkaZver deleted the feature/fix-protobuf-config branch July 29, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant