Remove legacy plugin ID and fix signing for Gradle Plugin Portal - #31
Merged
Conversation
- Remove mapstructLegacy plugin (com.github.akazver.mapstruct) - only io.github.akazver.mapstruct remains - Add signing keys to publish-gradle-portal job (required by vanniktech plugin) - Remove migration section from README (no longer needed) This fixes both publishing failures: - Gradle Plugin Portal: signing tasks now have configured signatory - Maven Central: no more 'Namespace com.github.akazver.mapstruct is not allowed' error
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix both publishing failures by removing the legacy plugin ID and adding signing keys to the Gradle Plugin Portal job.
Problem
After migrating to com.vanniktech.maven.publish, both publishing jobs failed:
Gradle Plugin Portal:
Cannot perform signing task because it has no configured signatorysignAllPublications()tried to sign plugin marker publications, but the job had no signing keys configuredMaven Central:
Namespace 'com.github.akazver.mapstruct' is not allowedcom.github.akazver.mapstructcreated a plugin marker publication that was being published to Maven Central, but this namespace is not registeredChanges
build.gradle
mapstructLegacyplugin definition (breaking change)io.github.akazver.mapstructplugin ID remains.github/workflows/main.yml
ORG_GRADLE_PROJECT_signingInMemoryKeyandORG_GRADLE_PROJECT_signingInMemoryKeyPasswordto thepublish-gradle-portaljobREADME.md
Testing
./gradlew clean build— BUILD SUCCESSFULBreaking Change
Users currently using
com.github.akazver.mapstructwill need to update toio.github.akazver.mapstruct. This is necessary because:Next Steps
After merging: