feat(presenter): isolate audio delay controls for redesign - #62
Draft
Shinokawa wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the audio-delay portion of #53 into its own draft so the API wiring and clock design can be reviewed without blocking mute or subtitle work.
The current implementation carries the original approach: it shifts decoded audio-frame PTS before the output ring buffer and wires
setAudioDelaythrough the full platform stack.Draft blockers
This implementation is intentionally not ready to merge:
The intended redesign is an audio delay processor with separate source and presentation timelines: positive changes insert output silence, negative changes trim queued samples, and the master position remains monotonic and truthful.
Validation
cargo fmt --all -- --checkcargo test -p erika -p erika_capi --lib— 391 + 26 tests passedflutter test— 37 tests passedSplit from #53; draft status documents the known semantic blocker.