fix: keep short MarkdownStream updates fully visible - #5671
Open
Alphaxiaoteng wants to merge 1 commit into
Open
Conversation
Clamp stable-line count to zero so a render shorter than live_window does not become a negative slice and drop leading lines. Fixes Aider-AI#5654.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
live_window,num_lines - live_windowbecomes negative andlines[num_lines:]keeps only a suffix (e.g. 4 lines with window 5 → only the last line).max(0, num_lines - live_window)so all early lines stay in the Rich live area until they are actually stable.Test plan
pytest tests/basic/test_mdstream_short_window.py -q→ 2 passedlive_window=5, 4 lines): all four lines retained in Livelive_window=6, 8 lines): first two printed above Live, last six retainedMade with Cursor