This repository was archived by the owner on Aug 23, 2026. It is now read-only.
Repository navigation
docs(quality): record rector/phpstan version coupling in the gate (AID-528) - #187
Merged
Merged
Conversation
…D-528) rector/rector hard-requires phpstan/phpstan (^2.2.2 as of 2.5.7), so rector, larastan and phpstan move as one unit. A rector minor can drag phpstan forward and silently change the @phpstan gate inside the same PR. Renovate is active on this repo, so that bump arrives unattended and the reviewer needs the warning where they will actually read it. Adopting rector did not move anything: phpstan stayed at 2.2.5 and larastan at v3.10.0 (verified against the lock diff of ea42fd6). The risk is the next upgrade, not the adoption. Learned from openmizan AID-526, which hit this while hardening the same gate. Documentation only — no behaviour change, refactor:dry still exits 0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only follow-up to #186. No behaviour change.
Why
rector/rector 2.5.7hard-requiresphpstan/phpstan ^2.2.2:So rector, larastan and phpstan move as one unit. A rector minor can drag phpstan forward and silently change the
@phpstangate inside the same PR — and Renovate is now active on this repo (#185), so that bump arrives unattended.The note goes in
rector.phpbecause that is what a reviewer opens when Renovate proposes a rector bump.Scope check
Adopting rector in #186 did not move anything — verified against the lock diff of
ea42fd6:phpstan/phpstanlarastan/larastanOnly
rector/rector 2.5.7anddriftingly/rector-laravel 2.5.0were added. The risk is the next upgrade, not the adoption.Learned from openmizan AID-526, which hit this while hardening the same gate.
Verification
composer check-full→ exit 0, 1442 passed / 16 skipped, coverage 89.8%.refactor:drystill exits 0.