Let ThrottledStream be a wrapper around WeightedStream - #7
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ThrottledStream implementation to be a thin wrapper around the existing WeightedStream, eliminating code duplication and improving maintainability. The refactor standardizes the API by making the token bucket optional in both stream types.
ThrottledStreamis now a wrapper aroundWeightedStreamwith a unit weight functionWeightedStreamnow accepts optional token buckets likeThrottledStream- Version bump from 0.0.1-alpha.6 to 0.0.1-alpha.7
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/futures/stream.rs | Refactored ThrottledStream to wrap WeightedStream, made token bucket optional in WeightedStream, added PhantomPinned marker |
| examples/streams.rs | Increased number of concurrent streams from 100 to 1000 for testing |
| Cargo.toml | Version bump to 0.0.1-alpha.7 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.