Skip to content

Move the remaining feature bindings out of the app module #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AhmadKharfan merged 1 commit into from
Jul 30, 2026
Merged

Move the remaining feature bindings out of the app module #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 0 additions & 82 deletions app/src/main/java/com/ahmadkharfan/androidstudiolite/di/GitModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,26 +22,12 @@ import com.ahmadkharfan.androidstudiolite.domain.repository.GitOperationMonitor
import com.ahmadkharfan.androidstudiolite.domain.repository.WorkspaceWriteGate
import com.ahmadkharfan.androidstudiolite.domain.usecase.CloneProjectUseCase
import com.ahmadkharfan.androidstudiolite.domain.usecase.ProjectPathResolver
import com.ahmadkharfan.androidstudiolite.feature.projects.clonerepo.CloneRepoViewModel
import com.ahmadkharfan.androidstudiolite.feature.editor.assets.AssetsViewModel
import com.ahmadkharfan.androidstudiolite.feature.git.api.GitPanelApi
import com.ahmadkharfan.androidstudiolite.feature.git.GitPanelApiImpl
import com.ahmadkharfan.androidstudiolite.feature.git.GitPanelViewModel
import com.ahmadkharfan.androidstudiolite.feature.git.diff.GitDiffViewModel
import com.ahmadkharfan.androidstudiolite.feature.git.history.GitBlameViewModel
import com.ahmadkharfan.androidstudiolite.feature.git.history.GitHistoryViewModel
import com.ahmadkharfan.androidstudiolite.feature.git.refs.GitRefsViewModel
import com.ahmadkharfan.androidstudiolite.feature.git.conflict.GitConflictViewModel
import com.ahmadkharfan.androidstudiolite.feature.settings.gitauth.GitAuthSettingsViewModel
import org.koin.android.ext.koin.androidContext
import org.koin.core.module.dsl.viewModel
import org.koin.core.module.dsl.viewModelOf
import org.koin.dsl.module

private val Context.gitAuthorDataStore: DataStore<Preferences> by preferencesDataStore(name = "git_author")

val gitModule = module {
single<GitPanelApi> { GitPanelApiImpl() }
single<GitCredentialStore> { EncryptedGitCredentialStore(androidContext()) }
single<GitHubDeviceAuthenticator> {
GitHubDeviceFlowAuthenticator(
Expand Down Expand Up @@ -75,75 +61,7 @@ val gitModule = module {
}


viewModelOf(::CloneRepoViewModel)


viewModel { params ->
GitPanelViewModel(
projectId = params.get(),
projectPathResolver = get(),
gitRepository = get(),
operationMonitor = get(),
credentialStore = get(),
authenticator = get(),
)
}
viewModel { params ->
GitDiffViewModel(
projectId = params[0],
path = params[1],
target = params[2],
commitId = params.get<String>(3).takeIf { it.isNotBlank() },
projectPathResolver = get(),
gitRepository = get(),
)
}
viewModel { params ->
GitHistoryViewModel(
projectId = params[0],

requestedPath = params.get<String>(1).takeIf { it.isNotBlank() },
projectPathResolver = get(),
gitRepository = get(),
)
}
viewModel { params ->
GitBlameViewModel(
projectId = params[0],
requestedPath = params[1],
projectPathResolver = get(),
gitRepository = get(),
)
}
viewModel { params ->
GitRefsViewModel(
projectId = params[0],
mode = params[1],
projectPathResolver = get(),
gitRepository = get(),
credentialStore = get(),
authenticator = get(),
)
}
viewModel { params ->
GitConflictViewModel(
projectId = params.get(),
projectPathResolver = get(),
gitRepository = get(),
)
}

viewModel { params ->
AssetsViewModel(
projectId = params.get(),
projectPathResolver = get(),
)
}
viewModel {
GitAuthSettingsViewModel(
credentialStore = get(),
authenticator = get(),
gitAuthorStore = get(),
)
}
}
2 changes: 2 additions & 0 deletions app/src/main/java/com/ahmadkharfan/androidstudiolite/di/KoinModules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package com.ahmadkharfan.androidstudiolite.di

import com.ahmadkharfan.androidstudiolite.core.network.NetworkMonitor
import com.ahmadkharfan.androidstudiolite.feature.editor.di.editorModule
import com.ahmadkharfan.androidstudiolite.feature.git.di.gitPresentationModule
import com.ahmadkharfan.androidstudiolite.feature.onboarding.di.onboardingModule
import com.ahmadkharfan.androidstudiolite.feature.projects.di.projectsModule
import com.ahmadkharfan.androidstudiolite.feature.settings.di.settingsModule
Expand All @@ -20,6 +21,7 @@ private val featureModules = listOf(
projectsModule,
terminalFeatureModule,
editorModule,
gitPresentationModule,
)

val appModules = listOf(dataModule, gradleModule)
Expand Down
Binary file modified ...imeToDirDebug_dex/com/ahmadkharfan/androidstudiolite/feature/editor/di/EditorModuleKt.dex
View file
Open in desktop
Binary file not shown.
Binary file added ...theticLambda$2$5e6e482122555406ffdab917a6a803e88f030b8e2d2aed741b55619167522c24$0.globals
View file
Open in desktop
Binary file not shown.
Binary file added ...theticLambda$2$5e6e482122555406ffdab917a6a803e88f030b8e2d2aed741b55619167522c24$1.globals
View file
Open in desktop
Binary file not shown.
Binary file added ...theticLambda$2$5e6e482122555406ffdab917a6a803e88f030b8e2d2aed741b55619167522c24$2.globals
View file
Open in desktop
Binary file not shown.
Binary file added ...theticLambda$2$5e6e482122555406ffdab917a6a803e88f030b8e2d2aed741b55619167522c24$3.globals
View file
Open in desktop
Binary file not shown.
Binary file modified ...f2c9ce196b82e5845fea8445c9f2c1b4/transformed/bundleLibRuntimeToDirDebug/desugar_graph.bin
View file
Open in desktop
Binary file not shown.
Binary file modified ...gKotlin/classes/com/ahmadkharfan/androidstudiolite/feature/editor/di/EditorModuleKt.class
View file
Open in desktop
Binary file not shown.
Binary file modified ...ld/intermediates/compile_library_classes_jar/debug/bundleLibCompileToJarDebug/classes.jar
View file
Open in desktop
Binary file not shown.
Binary file modified ...ntimeToDirDebug/com/ahmadkharfan/androidstudiolite/feature/editor/di/EditorModuleKt.class
View file
Open in desktop
Binary file not shown.
Binary file modified ...ld/intermediates/runtime_library_classes_jar/debug/bundleLibRuntimeToJarDebug/classes.jar
View file
Open in desktop
Binary file not shown.
Binary file modified ...entation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/inputs/source-to-output.tab
View file
Open in desktop
Binary file not shown.
Binary file modified ...uild/kotlin/compileDebugKotlin/cacheable/caches-jvm/inputs/source-to-output.tab.values.at
View file
Open in desktop
Binary file not shown.
Binary file modified ...ild/kotlin/compileDebugKotlin/cacheable/caches-jvm/jvm/kotlin/internal-name-to-source.tab
View file
Open in desktop
Binary file not shown.
Binary file modified .../compileDebugKotlin/cacheable/caches-jvm/jvm/kotlin/internal-name-to-source.tab.values.at
View file
Open in desktop
Binary file not shown.
Binary file modified ...ntation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/jvm/kotlin/package-parts.tab
View file
Open in desktop
Binary file not shown.
Binary file modified ...ild/kotlin/compileDebugKotlin/cacheable/caches-jvm/jvm/kotlin/package-parts.tab.values.at
View file
Open in desktop
Binary file not shown.
Binary file modified ...or/presentation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/jvm/kotlin/proto.tab
View file
Open in desktop
Binary file not shown.
Binary file modified ...ation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/jvm/kotlin/proto.tab.values.at
View file
Open in desktop
Binary file not shown.
Binary file modified ...ion/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/jvm/kotlin/source-to-classes.tab
View file
Open in desktop
Binary file not shown.
Binary file modified ...kotlin/compileDebugKotlin/cacheable/caches-jvm/jvm/kotlin/source-to-classes.tab.values.at
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion ...or/presentation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/counters.tab
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
63
64
0
Binary file modified .../presentation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/file-to-id.tab
View file
Open in desktop
Binary file not shown.
Binary file modified ...ion/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/file-to-id.tab.values.at
View file
Open in desktop
Binary file not shown.
Binary file modified .../presentation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/id-to-file.tab
View file
Open in desktop
Binary file not shown.
Binary file modified ...ion/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/id-to-file.tab.keystream
View file
Open in desktop
Binary file not shown.
Binary file modified ...build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/id-to-file.tab.keystream.len
View file
Open in desktop
Binary file not shown.
Binary file modified ...sentation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/id-to-file.tab.len
View file
Open in desktop
Binary file not shown.
Binary file modified ...ion/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/id-to-file.tab.values.at
View file
Open in desktop
Binary file not shown.
Binary file modified ...resentation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/id-to-file.tab_i
View file
Open in desktop
Binary file not shown.
Binary file modified ...tor/presentation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/lookups.tab
View file
Open in desktop
Binary file not shown.
Binary file modified ...tation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/lookups.tab.keystream
View file
Open in desktop
Binary file not shown.
Binary file modified ...on/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/lookups.tab.keystream.len
View file
Open in desktop
Binary file not shown.
Binary file modified ...presentation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/lookups.tab.len
View file
Open in desktop
Binary file not shown.
Binary file modified ...tation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/lookups.tab.values.at
View file
Open in desktop
Binary file not shown.
Binary file modified ...r/presentation/build/kotlin/compileDebugKotlin/cacheable/caches-jvm/lookups/lookups.tab_i
View file
Open in desktop
Binary file not shown.
Binary file modified feature/editor/presentation/build/kotlin/compileDebugKotlin/cacheable/last-build.bin
View file
Open in desktop
Binary file not shown.
8 changes: 4 additions & 4 deletions feature/editor/presentation/build/reports/detekt/detekt.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@ <h2>Complexity Report</h2>

<div>
<ul>
<li>12,749 lines of code (loc)</li>
<li>11,938 source lines of code (sloc)</li>
<li>8,817 logical lines of code (lloc)</li>
<li>12,753 lines of code (loc)</li>
<li>11,942 source lines of code (sloc)</li>
<li>8,819 logical lines of code (lloc)</li>
<li>2 comment lines of code (cloc)</li>
<li>2,748 cyclomatic complexity (mcc)</li>
<li>1,609 cognitive complexity</li>
Expand All @@ -188,7 +188,7 @@ <h2>Findings</h2>
<div>Total: 0</div>


generated with <a href="https://detekt.dev/">detekt version 1.23.8</a> on 2026-07-30 08:30:57 UTC.
generated with <a href="https://detekt.dev/">detekt version 1.23.8</a> on 2026-07-30 08:49:50 UTC.

</body>
</html>
24 changes: 12 additions & 12 deletions feature/editor/presentation/build/reports/tests/testDebugUnitTest/-pijNCGAqVQ/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ <h2>summary</h2>
</td>
<td>
<div class="infoBox duration">
<div class="counter">0.016s</div>
<div class="counter">0.024s</div>
<p>duration</p>
</div>
</td>
Expand Down Expand Up @@ -94,7 +94,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.001s</td>
<td>0s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -103,7 +103,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.002s</td>
<td>0s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -112,7 +112,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0s</td>
<td>0.001s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -121,7 +121,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0s</td>
<td>0.001s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -148,7 +148,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.001s</td>
<td>0.005s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -175,7 +175,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.001s</td>
<td>0s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -193,7 +193,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.004s</td>
<td>0.001s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -202,7 +202,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0s</td>
<td>0.002s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -229,7 +229,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0s</td>
<td>0.001s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand Down Expand Up @@ -283,7 +283,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.003s</td>
<td>0.001s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -308,7 +308,7 @@ <h2>summary</h2>
<input id="line-wrapping-toggle" type="checkbox" autocomplete="off"/>
</label>
</div>Generated by
<a href="https://www.gradle.org">Gradle 9.4.1</a> at Jul 30, 2026, 11:32:56 AM</p>
<a href="https://www.gradle.org">Gradle 9.4.1</a> at Jul 30, 2026, 11:49:52 AM</p>
</div>
</div>
</body>
Expand Down
12 changes: 6 additions & 6 deletions feature/editor/presentation/build/reports/tests/testDebugUnitTest/1Fkyp-_-sGc/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ <h2>summary</h2>
</td>
<td>
<div class="infoBox duration">
<div class="counter">0.015s</div>
<div class="counter">0.030s</div>
<p>duration</p>
</div>
</td>
Expand Down Expand Up @@ -94,7 +94,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.002s</td>
<td>0.001s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -103,7 +103,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.002s</td>
<td>0.003s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -112,7 +112,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.007s</td>
<td>0.011s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -121,7 +121,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0s</td>
<td>0.012s</td>
<td class="success">100%</td>
</tr>
</table>
Expand All @@ -137,7 +137,7 @@ <h2>summary</h2>
<input id="line-wrapping-toggle" type="checkbox" autocomplete="off"/>
</label>
</div>Generated by
<a href="https://www.gradle.org">Gradle 9.4.1</a> at Jul 30, 2026, 11:32:56 AM</p>
<a href="https://www.gradle.org">Gradle 9.4.1</a> at Jul 30, 2026, 11:49:52 AM</p>
</div>
</div>
</body>
Expand Down
10 changes: 5 additions & 5 deletions feature/editor/presentation/build/reports/tests/testDebugUnitTest/4B0iI80TQyw/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ <h2>summary</h2>
</td>
<td>
<div class="infoBox duration">
<div class="counter">0.001s</div>
<div class="counter">0.008s</div>
<p>duration</p>
</div>
</td>
Expand Down Expand Up @@ -94,7 +94,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0s</td>
<td>0.001s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand All @@ -103,7 +103,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.001s</td>
<td>0.003s</td>
<td class="success">100%</td>
</tr>
<tr>
Expand Down Expand Up @@ -139,7 +139,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0s</td>
<td>0.001s</td>
<td class="success">100%</td>
</tr>
</table>
Expand All @@ -155,7 +155,7 @@ <h2>summary</h2>
<input id="line-wrapping-toggle" type="checkbox" autocomplete="off"/>
</label>
</div>Generated by
<a href="https://www.gradle.org">Gradle 9.4.1</a> at Jul 30, 2026, 11:32:56 AM</p>
<a href="https://www.gradle.org">Gradle 9.4.1</a> at Jul 30, 2026, 11:49:52 AM</p>
</div>
</div>
</body>
Expand Down
6 changes: 3 additions & 3 deletions feature/editor/presentation/build/reports/tests/testDebugUnitTest/4SUFQfmjs38/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ <h2>summary</h2>
</td>
<td>
<div class="infoBox duration">
<div class="counter">0.007s</div>
<div class="counter">0.011s</div>
<p>duration</p>
</div>
</td>
Expand Down Expand Up @@ -103,7 +103,7 @@ <h2>summary</h2>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.004s</td>
<td>0.005s</td>
<td class="success">100%</td>
</tr>
</table>
Expand All @@ -119,7 +119,7 @@ <h2>summary</h2>
<input id="line-wrapping-toggle" type="checkbox" autocomplete="off"/>
</label>
</div>Generated by
<a href="https://www.gradle.org">Gradle 9.4.1</a> at Jul 30, 2026, 11:32:56 AM</p>
<a href="https://www.gradle.org">Gradle 9.4.1</a> at Jul 30, 2026, 11:49:52 AM</p>
</div>
</div>
</body>
Expand Down
Loading
Loading