Repository navigation
feat: SVG brand icons and Telegram integration - #42
Merged
Merged
Conversation
- New IntegrationIcon component with proper SVG paths for Slack, Telegram, GitHub, PagerDuty, Datadog, SNS, and Email - SettingsPage: Slack card and Coming Soon cards now use SVG icons - AlertDetailPage: notification channel rows use SVG icons instead of emoji - Closes prep work for #41 (Telegram integration)
Closes #41 - src/integrations/telegram.py: post_investigation + post_failed_investigation using Telegram Bot API sendMessage with HTML parse mode - appsettings.py: TELEGRAM_BOT_TOKEN and TELEGRAM_CHAT_ID env vars - integrations router: POST /api/integrations/telegram/test endpoint - event_consumer + poller: deliver to Telegram after Slack; tracked in alert_notifications with channel='telegram' - SettingsPage: Telegram promoted from Coming Soon to live card with configured/not-configured badge, .env hint, and Send test message button - tests/integration/test_telegram.py: 7 tests covering message rendering and bot API delivery (mirrors test_slack.py pattern) - .env.example: document TELEGRAM_BOT_TOKEN and TELEGRAM_CHAT_ID
…ars to Settings - _post() now returns (bool, error_detail) tuple so callers can see the raw Telegram error response instead of just False - POST /api/integrations/telegram/test raises HTTP 502 with the actual Telegram error body when delivery fails (was silently returning ok: true) - Settings Environment tab now shows TELEGRAM_BOT_TOKEN (masked) and TELEGRAM_CHAT_ID so users can verify both vars are loaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
Changes
SVG brand icons
IntegrationIconcomponent (frontend/src/components/icons/) with proper SVG paths for Slack, Telegram, GitHub, PagerDuty, Datadog, SNS, and Email — replaces all emoji placeholdersSettingsPageandAlertDetailPagenotification rows now use the SVG iconsTelegram integration
src/integrations/telegram.py—post_investigation+post_failed_investigationvia Telegram Bot API (sendMessage, HTML parse mode)TELEGRAM_BOT_TOKEN+TELEGRAM_CHAT_IDenv vars (both required to enable)POST /api/integrations/telegram/test— test endpoint matching Slack patternalert_notificationswithchannel='telegram'.envhint, and "Send test message" buttontests/integration/test_telegram.py(mirrorstest_slack.py)Pages to test
Test plan
deliveredin alert detailuv run pytest tests/integration/test_telegram.py— 7 passed