Repository navigation
Feat/mvp phase2 correctness - #4
Merged
Merged
Conversation
- tools/bash_tool.py: run_bash_command with prefix allowlist, 30s timeout,
shell=False, structured {success, output, error, command, blocked} return,
output capped at 4 KB, Loguru logging on every call
- Registered in ALL_TOOLS alongside existing 19 AWS tools
- prompts.py: bash tool rules — prefer boto3 tools first, explain reasoning,
never attempt state-modifying commands
- 49 tests covering allowlist, blocklist, timeout, exceptions, output capping,
result structure; all subprocess calls mocked with pytest-mock
- README: bash tool in What's inside, Security & Sandboxing section,
Phase 2 Docker sandbox item in Later roadmap
…ve no boto3 equivalent
Replace per-service prefix allowlist with verb-based check: any aws <service> <operation> where the operation starts with describe-, list-, get-, lookup-, filter-, search-, scan-, query, batch-get- is allowed — covering all AWS services, not just the 7 with boto3 tools. Blocked by operation verb: create, delete, update, put, run, invoke, terminate, stop, send, modify, etc. kubectl and docker keep exact prefix matching (narrower scope). System prompt updated to tell the agent it has full AWS CLI read-only access and should use it for any service not covered by boto3 tools. 83 tests passing.
- Dockerfile: two-stage build (uv deps + final), installs AWS CLI v2 so run_bash_command works on any server without manual setup - docker-compose.yml: backend + postgres (healthcheck) + nginx frontend; mounts ~/.aws read-only for dev; override with IAM role in production - frontend/Dockerfile: nginx production build - frontend/nginx.conf: proxy /chat /sessions /history /stats to backend, SSE-safe (proxy_buffering off), SPA fallback for React Router - .dockerignore: excludes .venv, node_modules, .env, tests, docs - README: Docker Compose as recommended run option, local dev as Option B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.