Skip to content

fix: add yaml consistency via yamllint - #54

Merged
Ahhhh-man merged 1 commit into
mainfrom
yamllint
Sep 20, 2025
Merged

fix: add yaml consistency via yamllint#54
Ahhhh-man merged 1 commit into
mainfrom
yamllint

Conversation

@Ahhhh-man

Copy link
Copy Markdown
Owner

No description provided.

@Ahhhh-man
Ahhhh-man requested a review from Copilot September 20, 2025 16:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces YAML consistency enforcement by adding yamllint to the development toolchain and applying its formatting rules across the project.

Key changes include:

  • Adding yamllint tool to the Nix development environment
  • Creating a yamllint configuration file with specific rules for the project
  • Reformatting YAML files to comply with yamllint standards (line length, indentation, quotes)

Reviewed Changes

Copilot reviewed 13 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
flake.nix Adds yamllint package to development dependencies
.yamllint Configuration file defining YAML linting rules and exceptions
examples/helmfile-serving-with-https.yaml New example file with proper YAML formatting
examples/helmfile-knative-serving-with-https.yaml Removed (likely renamed to above)
examples/helmfile-knative-minimal.yaml Simplified configuration with unused sections removed
charts/*/Chart.yaml Version bumps and description formatting fixes
charts/*/values.yaml Long comment lines reformatted to comply with line length limits
.github/workflows/release.yaml Quote style consistency fix
.github/ISSUE_TEMPLATE/*.yml Multi-line description formatting improvements
Comments suppressed due to low confidence (1)

examples/helmfile-knative-minimal.yaml:1

  • The removal of the domain-template and autocreate-cluster-domain-claims configuration options may break existing functionality that depends on these settings. These appear to be functional configuration changes rather than just formatting improvements.
repositories:

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Ahhhh-man
Ahhhh-man merged commit 2b0ec99 into main Sep 20, 2025
1 check passed
@Ahhhh-man
Ahhhh-man deleted the yamllint branch September 20, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants