fix(android): replace deprecated LocationRequest API for Play Services 21+ / Android 12+#453
Open
AmrithVengalath wants to merge 1 commit into
Conversation
…ationRequest.Builder for Play Services 21+ compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Apps with
targetSdkVersion >= 34crash withNoSuchMethodErrorwhen callingGeolocation.getCurrentPosition()on devices running Google Play Services 21.0.0+(standard on Android 12+ devices). The crash happens in native Java code and cannot
be caught by JavaScript try/catch.
Root cause:
FusedLocationProvider.javausesnew LocationRequest()and chainedsetter methods (
setPriority,setInterval,setFastestInterval,setSmallestDisplacement) that were removed in Play Services Location 21.0.0.The
LocationRequest.PRIORITY_*integer constants were also superseded by thePriorityinterface.Fix
new LocationRequest()+ setter chain withLocationRequest.BuilderLocationRequest.PRIORITY_*constants withPriority.PRIORITY_*PRIORITY_NO_POWER→Priority.PRIORITY_PASSIVE(same value, renamed)References