fix: drag-drop card reorder now persists in SA Data Contract

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: shagility-notabot

app/src/lib/adapters/standalone-adapter.ts

@@ -44,6 +44,9 @@ export function createStandaloneAdapter(callbacks: {
 	onSetPatternOverride?: (patternId: string, override: ContractPatternOverride) => void;
 	/** Optional: remove a pattern override (revert to static defaults for that pattern). */
 	onDeletePatternOverride?: (patternId: string) => void;
+	/** Optional: reorder an item within its containing array. Called when the
+	 *  shared CanvasSection drag-drop emits `properties.order` updates. */
+	onReorderItem?: (sourceId: string, newOrder: number) => void;
 }): DataAdapter {
 	function getSnapshot() {
 		return contractToContextPlane(callbacks.getModel());
@@ -159,10 +162,18 @@ export function createStandaloneAdapter(callbacks: {
 				if (updates.description !== undefined) nameOrDesc.description = updates.description;
 				if (Object.keys(nameOrDesc).length > 0) callbacks.onUpdateNode(sourceId, nameOrDesc);
 
-				if (updates.properties && callbacks.onUpdateItemProperties) {
-					// Strip out non-editable system properties
-					const { canvas: _c, sourceId: _s, order: _o, ...rest } = updates.properties as Record<string, unknown>;
-					if (Object.keys(rest).length > 0) callbacks.onUpdateItemProperties(sourceId, rest);
+				if (updates.properties) {
+					const props = updates.properties as Record<string, unknown>;
+					// Drag-drop reorder: shared CanvasSection emits per-card
+					// `properties.order` updates with the new 1-based slot.
+					if (typeof props.order === 'number' && callbacks.onReorderItem) {
+						callbacks.onReorderItem(sourceId, props.order);
+					}
+					if (callbacks.onUpdateItemProperties) {
+						// Strip system properties + `order` (handled above) before forwarding.
+						const { canvas: _c, sourceId: _s, order: _o, ...rest } = props;
+						if (Object.keys(rest).length > 0) callbacks.onUpdateItemProperties(sourceId, rest);
+					}
 				}
 			}
 

app/src/lib/stores/contract.svelte.ts

@@ -1073,6 +1073,33 @@ export function setExampleData(rows: ExampleDataRow[]) {
 // adapter routes those calls into these mutators so the changes land on the
 // model and survive page reload.
 
+/**
+ * Move an item to a new position within its containing array, given its raw
+ * ContractItem id and the new 1-based order. Used by the shared
+ * CanvasSection's drag-drop reorder. The converter emits `order: i + 1` per
+ * item, so reorder requests come in 1-based — we splice to slot `order - 1`.
+ *
+ * Searches all known array fields for the item; no entity-label mapping
+ * needed. No-op if the item isn't found or the slot doesn't change.
+ */
+export function reorderItem(itemId: string, newOrder: number) {
+	const arrays: (keyof ContractModel)[] = [
+		'team', 'personas', 'columns', 'glossaryTerms',
+		'deliveryTypes', 'trustRules', 'dataSyncs', 'lineage'
+	];
+	for (const field of arrays) {
+		const arr = store.model[field] as ContractItem[];
+		const fromIdx = arr.findIndex((i) => i.id === itemId);
+		if (fromIdx === -1) continue;
+		const toIdx = Math.max(0, Math.min(arr.length - 1, newOrder - 1));
+		if (fromIdx === toIdx) return;
+		const [moved] = arr.splice(fromIdx, 1);
+		arr.splice(toIdx, 0, moved);
+		markDirty();
+		return;
+	}
+}
+
 /** Replace the per-contract list of pattern types. `null` = use static defaults. */
 export function setPatternTypes(types: ContractPatternType[] | null) {
 	store.model.patternTypes = types;

app/src/routes/+page.svelte

@@ -18,7 +18,8 @@
 		migrateModel,
 		setPatternTypes,
 		setPatternOverride,
-		deletePatternOverride
+		deletePatternOverride,
+		reorderItem
 	} from '$lib/stores/contract.svelte';
 	import { contractToContextPlane, contextPlaneToContract } from '$lib/converters/context-plane';
 	import { seedDemoIfEmpty } from '$lib/stores/demo-seed';
@@ -108,6 +109,13 @@
 			deletePatternOverride(patternId);
 			clearTimeout(orderSaveTimer);
 			orderSaveTimer = setTimeout(() => saveModel(), 300);
+		},
+		onReorderItem: (sourceId, newOrder) => {
+			reorderItem(sourceId, newOrder);
+			// Drag-drop fires N updateNode calls in sequence (one per affected
+			// card). Debounce so we save once after the whole reorder lands.
+			clearTimeout(orderSaveTimer);
+			orderSaveTimer = setTimeout(() => saveModel(), 300);
 		}
 	});
 	setContext('dataAdapter', adapter);