fix: isolate $data demo-seed imports from CP build graph

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: shagility-notabot

app/src/lib/stores/contract.svelte.ts

@@ -524,18 +524,13 @@ function lsSaveAll(models: Record<string, ContractModel>): void {
 	localStorage.setItem(LS_KEY, JSON.stringify(models));
 }
 
-// Seed JSONs imported at build time so the demo starts populated. The publish
-// flow copies these files from `../data/*.json` into the public repo (see
-// `scripts/publish-app.sh`'s data-file copy step) so the imports resolve at
-// build time both in the monorepo and in the standalone clone.
-import stripeCustomersSeed from '$data/stripe-customers-contract.json';
-import stripeSubscriptionsSeed from '$data/stripe-subscriptions-contract.json';
-import stripeInvoicesSeed from '$data/stripe-invoices-contract.json';
-const DEMO_SEED_MODELS: ContractModel[] = [
-	stripeCustomersSeed as unknown as ContractModel,
-	stripeSubscriptionsSeed as unknown as ContractModel,
-	stripeInvoicesSeed as unknown as ContractModel
-];
+// NOTE: demo-mode seed imports live in `./demo-seed.ts`, NOT here. That file
+// uses the `$data` Vite alias (only defined in the standalone app's own
+// vite.config.ts) and is imported only by the SA `+page.svelte`. The Context
+// Plane frontend transitively imports this store through the data-contract
+// package's converter exports, so any `$data/...` imports added at module
+// scope here would break the CP dev build with "Failed to resolve import".
+// Keep that aliased path confined to demo-seed.ts.
 
 // --- API helpers -----------------------------------------------------------
 
@@ -738,19 +733,13 @@ function makeExampleModel(): ContractModel {
 
 export async function initStore() {
 	if (store.loaded) return;
-	let models = await apiListModels();
-
-	// In demo mode, if localStorage is empty seed all four example contracts
-	// (3 Stripe + 1 Receipts) so visitors land on a populated app instead of
-	// a single example. Normal SA install seeds just the example contract via
-	// the existing `models.length === 0` branch below.
-	if (DEMO_MODE && models.length === 0) {
-		for (const m of DEMO_SEED_MODELS) {
-			const migrated = migrateModel(JSON.parse(JSON.stringify(m)) as Record<string, unknown>);
-			await apiCreateModel(migrated);
-		}
-		models = await apiListModels();
-	}
+	const models = await apiListModels();
+
+	// Demo-mode seeding (when localStorage is empty) is handled by the SA
+	// `+page.svelte` calling `seedDemoIfEmpty()` from `./demo-seed.ts` BEFORE
+	// initStore runs. The store stays generic so the CP frontend can import
+	// this module via the converter without pulling in the SA-only `$data`
+	// alias.
 
 	if (models.length === 0) {
 		const example = makeExampleModel();

app/src/lib/stores/demo-seed.ts

@@ -0,0 +1,53 @@
+// Demo-mode seed for the standalone GitHub Pages build.
+//
+// This file imports the example contract JSONs via the `$data` Vite alias
+// (defined in `apps/data-contract/app/vite.config.ts`). It is therefore
+// only safe to import from the standalone app's own entrypoints (e.g.
+// `+page.svelte`). The Context Plane frontend transitively imports
+// `contract.svelte.ts` through the data-contract package's converter
+// exports, but does NOT import this file — keeping the `$data`-resolved
+// imports out of CP's build graph.
+//
+// `seedDemoIfEmpty()` runs once at SA app startup when
+// `VITE_DEMO_MODE=true`. It checks localStorage; if the demo store is
+// empty, it migrates and writes each example contract under the same
+// localStorage key the store uses.
+
+import type { ContractModel } from '../types';
+import { migrateModel } from './contract.svelte';
+
+import stripeCustomersSeed from '$data/stripe-customers-contract.json';
+import stripeSubscriptionsSeed from '$data/stripe-subscriptions-contract.json';
+import stripeInvoicesSeed from '$data/stripe-invoices-contract.json';
+
+const LS_KEY = 'data-contract-demo-models';
+
+const SEEDS: ContractModel[] = [
+	stripeCustomersSeed as unknown as ContractModel,
+	stripeSubscriptionsSeed as unknown as ContractModel,
+	stripeInvoicesSeed as unknown as ContractModel
+];
+
+/**
+ * Seed the demo localStorage with the bundled example contracts when empty.
+ * Call this from the standalone `+page.svelte` `onMount` BEFORE `initStore()`,
+ * gated by `VITE_DEMO_MODE === 'true'`. No-op if localStorage already has
+ * any contracts (so user-modified state wins after the first visit).
+ */
+export function seedDemoIfEmpty(): void {
+	if (typeof window === 'undefined') return;
+	let existing: Record<string, unknown> = {};
+	try {
+		const raw = localStorage.getItem(LS_KEY);
+		existing = raw ? JSON.parse(raw) : {};
+	} catch {
+		existing = {};
+	}
+	if (Object.keys(existing).length > 0) return;
+	const seeded: Record<string, ContractModel> = {};
+	for (const m of SEEDS) {
+		const migrated = migrateModel(JSON.parse(JSON.stringify(m)) as Record<string, unknown>);
+		seeded[migrated.id] = migrated;
+	}
+	localStorage.setItem(LS_KEY, JSON.stringify(seeded));
+}

app/src/routes/+page.svelte

@@ -21,6 +21,7 @@
 		deletePatternOverride
 	} from '$lib/stores/contract.svelte';
 	import { contractToContextPlane, contextPlaneToContract } from '$lib/converters/context-plane';
+	import { seedDemoIfEmpty } from '$lib/stores/demo-seed';
 	import { contractToRtf } from '$lib/converters/rtf';
 	import { contractToHtml } from '$lib/converters/word';
 	import { createStandaloneAdapter } from '$lib/adapters/standalone-adapter';
@@ -111,7 +112,14 @@
 	});
 	setContext('dataAdapter', adapter);
 
-	onMount(() => {
+	onMount(async () => {
+		// In demo mode (GitHub Pages static build), seed the example contracts
+		// into localStorage on first visit so the app starts populated. The
+		// seed module is imported only here in the SA entrypoint — not in the
+		// shared store — so the `$data/...` build-time imports stay out of the
+		// CP frontend's dependency graph.
+		const demo = (import.meta as { env?: { VITE_DEMO_MODE?: string } }).env?.VITE_DEMO_MODE === 'true';
+		if (demo) seedDemoIfEmpty();
 		initStore();
 	});