feat(deploy): inherit GitHub App installations#217
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
|
Warning Review limit reached
More reviews will be available in 50 minutes and 7 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds support for GitHub App installation inheritance in the relayfile deploy connector. When connecting GitHub via deployer-user scope, the client now opts into an installation flow that attempts to reuse existing org installations before falling back to fresh authentication, with end-to-end test coverage. ChangesGitHub App Installation Connection Flow
🎯 4 (Complex) | ⏱️ ~45 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
|
Fixed one issue in the PR’s GitHub installation flow: reconcile/join now re-resolves Added a regression test proving reconcile and join use the refreshed token after the sleep/poll boundary: connect.test.ts. Validation run: Addressed comments
|
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
|
Fixed a real issue in the GitHub installation fallback path: after OAuth polling, the second connect-session request now resolves the latest workspace token instead of reusing the pre-OAuth token. Added a regression test covering the fallback install flow and auth header sequence. Addressed comments
Verification:
Changed: I am not printing |
|
Fixed a real regression in the PR’s GitHub installation fallback path: after OAuth/reconcile polling refreshes the workspace token, the fresh install-session fallback now re-resolves the token instead of reusing the stale initial token. Fixed in Added a regression test covering the no-inheritable-org fallback and verifying the OAuth session, reconcile request, fallback install session, and final status poll all use the expected refreshed token sequence. Test added in Validation run: Addressed comments
I did not print |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed the PR diff and changed files. I made no source edits in this run because the current checkout already contains the token-refresh fixes raised in prior review notes, and I did not reproduce additional breakage in the changed GitHub installation flow. Validation run locally: GitHub API currently reports PR #217 is already merged/closed, so I am not printing Addressed comments
|
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed PR #217 against the current checkout. I did not make source edits because the current code already contains the validated token-refresh fixes and I did not reproduce additional breakage in the PR-changed flow. Validation run:
Addressed comments
I am not printing |
|
pr-reviewer could not complete review for #217 in AgentWorkforce/workforce. |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. pr-reviewer could not complete review for #217 in AgentWorkforce/workforce. |
|
Reviewed the PR diff and changed files. I made no source edits because the current checkout already contains the token-refresh fixes raised by prior bot comments, and I did not reproduce additional breakage in the PR-changed flow. Verification:
GitHub reports PR #217 as Addressed comments
|
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed PR #217 against the current checkout. I made no source edits: the previously raised token-refresh issues are already fixed in the checked-out code, and I did not reproduce additional breakage in the changed GitHub installation flow. Verification run: GitHub API shows PR #217 is already Addressed comments
|
Phase
Phase 5 — seamless GitHub App installation flow wiring (workforce CLI companion).
Summary
relayfileIntegrationResolverfor default GitHub deployer-user connects to opt into cloud's GitHub installation flow./github/reconcile, and calls/github/joinwhen an organization already has the App.github-relayinstall session when the flow is disabled or no inheritable organization installation is found.Gate evidence
origin/main644c3b0.pnpm install --frozen-lockfilepassed.pnpm --filter @agentworkforce/persona-kit build && pnpm --filter @agentworkforce/runtime build && pnpm --filter @agentworkforce/deploy buildpassed.pnpm --filter @agentworkforce/deploy testpassed: 178 tests.git diff --checkpassed.User-visible gate
integrations.github: already connected via <org>; using <workspace>and does not request a fresh install session.Linked PRs
Rollback