fix: unwrap app.call envelopes, clean up opencode diagnostics, and align test contracts#112
Closed
andrewwhitecdw wants to merge 1 commit into
Closed
Conversation
|
|
Contributor
Author
|
Gah I didnt catch the conflicts, working on it. |
andrewwhitecdw
force-pushed
the
bugfix/runtime-envelope-unwrap-diagnostics
branch
from
July 23, 2026 16:12
2a6fff4 to
f44e10e
Compare
…ign test contracts - Unwrap AgentField execution envelopes in fast_verify, dag_executor replanner, and app.py issue writers / execute_fn_target / resume_build. - Fix fast planner _note() to catch AgentFieldClientError so tests and detached-router runs don't crash. - Clean up opencode/client.py diagnostics: move logger below imports, guard empty schema files, and use debug-level logging for routine paths. - Re-comment placeholder ZHIPU_API_KEY in .env.example; keep ZHIPU_API_KEY env wiring in docker-compose.yml and revert control-plane port to 8080. - Align requirements.txt agentfield pin with requirements-docker.txt (>=0.1.41) and add pytest-asyncio to pyproject.toml dev deps. - Update stale verifier/node_id/integration tests to match current implementation and environment.
andrewwhitecdw
force-pushed
the
bugfix/runtime-envelope-unwrap-diagnostics
branch
from
July 23, 2026 16:17
f44e10e to
0af01a0
Compare
Contributor
Author
|
Closing this PR. The contributor is unable to sign the CLA, so these changes will remain in a private fork instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several runtime bugs where AgentField execution envelopes were not unwrapped before being used, cleans up noisy diagnostic logging in the OpenCode provider, and brings stale tests back in line with the current implementation.
Changes
swe_af/fast/verifier.py: unwrapapp.call()result before buildingFastVerificationResult.swe_af/execution/dag_executor.py: unwrap replannercall_fn()result before constructingReplanDecision.swe_af/app.py: unwrap issue-writer results, externalexecute_fn_targetreturns, andresume_buildoutput.swe_af/fast/planner.py: catchException(AgentField raisesAgentFieldClientError) in_note()so detached-router runs don't crash.swe_af/agent_ai/providers/opencode/client.py: move logger below imports, add empty-file guard, and downgrade routine diagnostics from warning to debug.ZHIPU_API_KEYin.env.example.ZHIPU_API_KEYenv wiring indocker-compose.ymland revert control-plane port to default 8080.requirements.txtagentfield pin withrequirements-docker.txt(>=0.1.41).pytest-asynciotopyproject.tomldev dependencies.fast_verifycontract.Verification
Tested with Python 3.12 and
agentfield>=0.1.41: