Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions go/internal/config/buildconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type BuildConfig struct {
EnableIntegrationTesting bool `json:"enable_integration_testing"`
MaxCodingIterations int `json:"max_coding_iterations"`
AgentMaxTurns int `json:"agent_max_turns"`
DeterministicGit bool `json:"deterministic_git"`
ExecuteFnTarget string `json:"execute_fn_target"`
PermissionMode string `json:"permission_mode"`
RepoURL string `json:"repo_url"`
Expand Down Expand Up @@ -69,6 +70,7 @@ func defaultBuildConfig() BuildConfig {
MaxIntegrationTestRetries: 1,
EnableIntegrationTesting: true,
MaxCodingIterations: 5,
DeterministicGit: true,
AgentMaxTurns: DefaultAgentMaxTurns,
ExecuteFnTarget: "",
PermissionMode: "",
Expand Down Expand Up @@ -268,6 +270,7 @@ func (c *BuildConfig) ToExecutionConfigDict() map[string]any {
"enable_integration_testing": c.EnableIntegrationTesting,
"max_coding_iterations": c.MaxCodingIterations,
"agent_max_turns": c.AgentMaxTurns,
"deterministic_git": c.DeterministicGit,
"agent_timeout_seconds": c.AgentTimeoutSeconds,
"max_advisor_invocations": c.MaxAdvisorInvocations,
"enable_issue_advisor": c.EnableIssueAdvisor,
Expand Down
2 changes: 2 additions & 0 deletions go/internal/config/executionconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ type ExecutionConfig struct {
EnableIntegrationTesting bool `json:"enable_integration_testing"`
MaxCodingIterations int `json:"max_coding_iterations"`
AgentMaxTurns int `json:"agent_max_turns"`
DeterministicGit bool `json:"deterministic_git"`
PermissionMode string `json:"permission_mode"`
AgentTimeoutSeconds int `json:"agent_timeout_seconds"`
MaxAdvisorInvocations int `json:"max_advisor_invocations"`
Expand Down Expand Up @@ -45,6 +46,7 @@ func defaultExecutionConfig() ExecutionConfig {
EnableIntegrationTesting: true,
MaxCodingIterations: 5,
AgentMaxTurns: DefaultAgentMaxTurns,
DeterministicGit: true,
PermissionMode: "",
AgentTimeoutSeconds: 2700,
MaxAdvisorInvocations: 2,
Expand Down
4 changes: 2 additions & 2 deletions go/internal/dag/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func RunDAG(
cleanupDone = make(chan struct{})
go func() {
cleanupErr = cleanupWorktrees(ctx, dagState, branches, callFn, nodeID, note,
level, cfg.GitModel(), cfg.AIProvider(), completed)
level, cfg.GitModel(), cfg.AIProvider(), cfg.DeterministicGit, completed)
close(cleanupDone)
}()
}
Expand Down Expand Up @@ -536,7 +536,7 @@ mainLoop:
[]string{"execution", "worktree_cleanup", "final_sweep"})
}
if err := cleanupWorktrees(ctx, dagState, allBranches, callFn, nodeID, note,
dagState.CurrentLevel, cfg.GitModel(), cfg.AIProvider(), nil); err != nil {
dagState.CurrentLevel, cfg.GitModel(), cfg.AIProvider(), cfg.DeterministicGit, nil); err != nil {
return nil, err
}
}
Expand Down
4 changes: 2 additions & 2 deletions go/internal/dag/gates.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func executeSingleIssue(
if result.Outcome == schemas.IssueOutcomeCompleted || result.Outcome == schemas.IssueOutcomeCompletedWithDebt {
result.Adaptations = adaptations
result.DebtItems = debtItems
result.FinalAcceptanceCriteria = asStringSlice(currentIssue["acceptance_criteria"])
result.FinalAcceptanceCriteria = schemas.StrList(asStringSlice(currentIssue["acceptance_criteria"]))
return result, nil
}

Expand Down Expand Up @@ -218,7 +218,7 @@ func executeSingleIssue(
AdvisorInvocations: advisorRound + 1,
Adaptations: adaptations,
DebtItems: debtItems,
FinalAcceptanceCriteria: asStringSlice(currentIssue["acceptance_criteria"]),
FinalAcceptanceCriteria: schemas.StrList(asStringSlice(currentIssue["acceptance_criteria"])),
IterationHistory: result.IterationHistory,
}, nil

Expand Down
Loading
Loading