fix: close generation races and tighten execution boundaries - #10
Merged
Conversation
Cancel the exact in-flight provider runner, fail loudly when first-run repair collides with an active generation, and re-validate HTTP, git, shell, approval, and GitHub update paths at the execution boundary.
Drop the AI tells, keep the facts, and say what Bar Tender actually does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the code quality report findings on
develop: generation races, execution-boundary gaps, the Swift 6 isolation warning, and the listed hygiene items.Correctness
generateToolfail loudly if another generation is already active.StatusItemManager.maximumIndividualItemsisnonisolated(Swift 6 default-argument warning).Security
http(s)+ host, treat 3xx as unhealthy unless an expected status is set, and strip userinfo from displayed URLs.api.github.com; release pages to HTTPS GitHub hosts.Hygiene
store.storageURL;build_and_run.shonly kills the debug bundle;PortProbecancels on task cancellation; window opening is installed from a one-shot command task.AppModel; runtime is injectable.Policy regexes remain advisory UX, not
sandbox-exec. Documented inSECURITY.md.Docs
Rewrote the README and the other project docs in plain language. Facts are unchanged. LICENSE and the code of conduct were left alone.
Tests
swift test: 181 passed. Added coverage for exact-runner cancel, first-run vs concurrent generation, HTTP boundary validation, fingerprint NUL, git-chardening, and GitHub host allowlists.