fix(tests): stop persistence cleanup from throwing on unlinked sockets - #21
Open
Aforno wants to merge 1 commit into
Open
fix(tests): stop persistence cleanup from throwing on unlinked sockets#21Aforno wants to merge 1 commit into
Aforno wants to merge 1 commit into
Conversation
FileManager.removeItem on a unix socket whose path stop() already unlinked failed the macos-15 release suite with NSCocoaErrorDomain code 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main CI failed on
macos-15release tests after merging #19:SessionPersistenceTests.testRuntimeDoesNotPromoteProviderTelemetryForRejectedProtocolthrewNSCocoaErrorDomaincode 4 (“an-….sock” couldn’t be removed, POSIX ENOENT).stop()alreadyunlinks the event socket. Fixture teardown then calledFileManager.removeItemon that same path. Debug andmacos-14passed; this showed up in the release suite.Fix
FileManagerto delete them.protocolMismatchDetectedinstead of a fixed 150ms sleep.Verified locally:
swift test,swift test -c release,./script/check_repository.sh.