fix(desktop): keep notch panel frame under AppKit control - #18
Merged
Conversation
- host SwiftUI in a fixed AppKit content view so layout animation cannot resize the panel - drop hosting safe-area insets and always disable SwiftUI sizing options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SwiftUI was still able to influence the notch panel frame.
NSHostingViewwas the window content view, so hosted layout animation could fight AppKit for bounds even with sizing options cleared on newer macOS.Host the SwiftUI tree in a plain
NotchPanelContentViewthat AppKit owns. The hosting view fills that view and autoresizes with it. Always clearsizingOptions(no macOS 13 availability gate) and drop hosting safe-area regions so SwiftUI layout animates inside a fixed panel frame.Verification
swift testswift test -c release./script/package_release.sh --adhoc./script/check_repository.shCovered by
testPanelKeepsHostingViewBehindAppKitSizingBoundary. Smoke-test expand/collapse and compact-to-detail so the panel frame stays under AppKit while SwiftUI layout animates inside it.Compatibility and risk
Desktop-only AppKit hosting change. No persistence, protocol, signing, or migration impact.
sizingOptions = []is no longer gated to macOS 13; confirm the deployment target still matches that API. Safe-area regions are cleared on the hosting view, so notch content no longer inherits window safe-area insets.Screenshots
Not applicable.