refactor(network): manage routing with SystemConfiguration - #32
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace direct host route mutation and route-table parsing with an owned
SystemConfiguration Network Service on the managed Ethernet Bond. macOS
SystemConfiguration/configd now owns route synthesis and reconciliation, while
the user retains control of network-service priority.
Changes
RouteCommandRunner, the explicit global/scoped/1route model, andinstalled-prefix status/UI
router, DNS, and disabled IPv6 through public SystemConfiguration APIs
path without claiming a kernel route-table acknowledgement
transaction and retain exact ownership metadata for restart cleanup
Related issue
None.
Validation
./script/build_and_run.sh --verify./script/build_and_install.shapproved entitlements and physical hardware. Verified instead with:
plutil -lintfor the project, plists, and entitlementsxmllint --nooutfor both shared schemesjq empty ThruRNDIS/Resources/Localizable.xcstringsxcodebuild -project ThruRNDIS.xcodeproj -listCODE_SIGNING_ALLOWED=NOgit diff --checkUser-facing impact
The managed Network Service appears in macOS network settings without changing
the user's service priority. Debug Settings no longer reports explicit
/1prefixes, and event logs describe the verified managed network path rather than
claiming that a kernel route is active. No screenshot is needed for the removed
debug-only row.
Security and architecture
All host network mutation remains in the authenticated privileged helper. The
helper no longer executes
/sbin/route, parsesnetstat, uses routing sockets,or links private SystemConfiguration symbols. Bond and Network Service ownership
remain bound to the recorded service identifier and SystemConfiguration
metadata; cleanup touches only those recorded objects.
Checklist
fix(usb): serialize detach handling.Afcoo/ThruRNDIS_VM_Assets.