Skip to content

fix(ui): clarify network start prompt - #29

Merged
Afcoo merged 1 commit into
mainfrom
fix/usb-network-prompt-copy
Aug 30, 2026
Merged

Afcoo merged 1 commit into
mainfrom
fix/usb-network-prompt-copy

Conversation

@Afcoo

@Afcoo Afcoo commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Summary

Clarify the detected USB prompt so accepting it communicates that networking will start through the device instead of only mentioning VM attachment.

Changes

  • Update the English prompt to Start networking through this device?.
  • Update the Korean prompt to 이 기기로 네트워크를 연결할까요?.
  • Keep USB attachment and automatic network-start behavior unchanged.

Related issue

None.

Validation

  • ./script/build_and_run.sh --verify
  • Checks run and unverified runtime paths are documented
  • Signed Runtime validation with ./script/build_and_install.sh
  • Real USB/VZNAT route validation
  • Not applicable; explanation: runtime launch, signing, and real-device validation are unnecessary for this copy-only change.

Checks performed:

  • String catalog JSON validation with jq empty
  • Project, plist, and entitlement validation with plutil -lint
  • Shared scheme XML validation with xmllint --noout
  • Project and scheme discovery with xcodebuild -list
  • Unsigned Debug build with CODE_SIGNING_ALLOWED=NO — succeeded

User-facing impact

The USB approval prompt now states that accepting will start networking through the detected device. No screenshot is included because this is a copy-only change to the existing alert.

Security and architecture

None. USB, VM lifecycle, host routes, privileged-helper behavior, signing, and VM Assets are unchanged.

Checklist

  • The pull request has one focused purpose.
  • The title follows Conventional Commits, for example fix(usb): serialize detach handling.
  • Behavior changes include appropriate build or runtime validation, with unavailable paths explained.
  • User-facing behavior and operational changes are documented.
  • New, moved, renamed, or deleted Swift files are reflected in Xcode groups, target membership, and build phases.
  • No credentials, provisioning profiles, personal signing values, or local build artifacts are included.
  • Guest VM scripts and VM Asset build tooling remain in Afcoo/ThruRNDIS_VM_Assets.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T16:28:46.315748Z 29a3dda PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Afcoo Afcoo changed the title fix(usb): clarify network start prompt fix(ui): clarify network start prompt Aug 30, 2026
@Afcoo
Afcoo merged commit e049f74 into main Aug 30, 2026
2 checks passed
@Afcoo
Afcoo deleted the fix/usb-network-prompt-copy branch August 30, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant