feat(network): add debug routing controls - #26
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add debug-only menu bar controls for Network Routing and keep routing manual when USB passthrough is requested from explicit controls in debug mode.
Changes
allowsAutomaticNetworkRoutingStartpolicy through asynchronous VM and passthrough work.Related issue
None.
Validation
./script/build_and_run.sh --verifygit diff --checkplutil -lintfor the project, property lists, and entitlementsxmllint --nooutfor shared schemesxcodebuild -project ThruRNDIS.xcodeproj -listxcodebuild -project ThruRNDIS.xcodeproj -scheme ThruRNDIS -configuration Debug -derivedDataPath /tmp/ThruRNDIS-Review-DerivedData CODE_SIGNING_ALLOWED=NO build./script/build_and_install.shThe app was not launched during unsigned validation. Signed helper, AccessoryAccess, real RNDIS passthrough, and host Bond/feth/bridge/route behavior remain unverified.
User-facing impact
When Debug Mode is enabled, the menu bar now exposes Network Routing Start/Restart and Stop actions immediately above Settings. USB attachment from Settings, the menu bar, or the replacement flow leaves routing stopped until an explicit Start; attachment accepted through the detected-device prompt retains automatic routing. No screenshot was captured because the app was not launched during validation.
Security and architecture
Host network mutation and the helper XPC contract are unchanged. The app only controls whether a successful USB attachment arms the existing
NetworkRouteStorereconciliation; all Bond, feth, bridge, and route mutation remains inThruRNDISPrivilegedHelper.Checklist
fix(usb): serialize detach handling.Afcoo/ThruRNDIS_VM_Assets.