feat(usb): improve accessory selection and replacement - #24
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2e9e28dc3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Improves how USB accessories are presented and managed in Settings, including selection-aware actions and confirmed replacement of an attached accessory.
Changes
Related issue
None.
Validation
./script/build_and_run.sh --verify— not run because it terminates any currently running ThruRNDIS instance.xcodebuild -project ThruRNDIS.xcodeproj -scheme ThruRNDIS -configuration Debug CODE_SIGNING_ALLOWED=NO buildxcodebuild -project ThruRNDIS.xcodeproj -listplutil -lintfor the project, plists, and entitlementsgit diff --check./script/build_and_install.shUser-facing impact
The USB Devices settings section now uses a table, clearly marks the attached device, derives action availability from the selected row, and asks for confirmation before replacing an attached device. No screenshot is included because an unsigned build cannot enumerate AccessoryAccess USB devices.
Security and architecture
USB replacement reuses the existing managed-network cleanup and VM restart workflow so a new accessory is attached only in a new VM session. No privileged-helper, XPC, entitlement, host-route contract, VM Asset, security, or privacy changes are included.
Checklist
Afcoo/ThruRNDIS_VM_Assets.