Repository navigation
Add app registration handling and update version to 0.2.2 - #12
Merged
Merged
Conversation
…st for reconnect behavior after retry exhaustion
…ge server IP address in example server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the service discovery mechanism and subscription handling in the Sero project, along with version updates and a new regression test. The main focus is on ensuring subscriptions are correctly reactivated after provider reconnections, even if retries were previously exhausted, and clarifying the distinction between app-registered and active subscriptions.
Service Discovery and Subscription Improvements:
app_registeredflag to theSubTrackerstruct inServiceDiscovery, ensuring subscriptions are only reactivated on provider reconnect if the app still wants them. This clarifies the difference between subscriptions requested by the app and those merely active.app_registeredtotruewhen subscribing andfalsewhen unsubscribing, preventing unwanted reactivation of subscriptions after reconnects. [1] [2]Testing Enhancements:
Version Updates:
CMakeLists.txtand Node modulepackage.jsonfrom0.2.1to0.2.2. [1] [2]Network Configuration:
examples/server.cppfrom127.0.0.1to192.168.1.132.