Skip to content

Fix Metal tests to SKIP instead of FAIL when Apple Silicon GPU is unavailable #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix Metal tests to SKIP instead of FAIL when Apple Silicon GPU is unavailable #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e3583b
Initial plan
Copilot Aug 6, 2026
82f7b3c
Fix Metal tests to skip instead of fail when Apple Silicon GPU is una…
Copilot Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/ComputeTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );

Matrix4x4 projection{};
Expand Down
27 changes: 27 additions & 0 deletions tests/RenderTestWindow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,5 +206,32 @@ namespace AeonGames
return nullptr;
}
}

/** @brief Construct a renderer with custom settings, returning nullptr
* (instead of throwing) when the backend is unavailable on the host. */
inline std::unique_ptr<Renderer> TryConstructRenderer ( const char* aRendererName, void* aWindow, const RendererSettings& aSettings )
{
#ifdef AEON_TEST_HAVE_VULKAN
if ( std::string_view{ aRendererName } == "Vulkan" && !IsVulkanAvailableOnHost() )
{
std::cerr << aRendererName << " renderer unavailable on this host: no compatible Vulkan driver." << std::endl;
return nullptr;
}
#endif
try
{
return ConstructRenderer ( std::string ( aRendererName ), aWindow, aSettings );
}
catch ( const std::exception& e )
{
std::cerr << aRendererName << " renderer unavailable on this host: " << e.what() << std::endl;
return nullptr;
}
catch ( ... )
{
std::cerr << aRendererName << " renderer unavailable on this host." << std::endl;
return nullptr;
}
}
}
#endif
71 changes: 55 additions & 16 deletions tests/RendererParityTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );

Mesh mesh;
Expand Down Expand Up @@ -338,7 +341,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );

Mesh mesh;
Expand Down Expand Up @@ -379,7 +385,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );
renderer->SetClearColor ( window, 0.0f, 0.0f, 0.0f, 1.0f );
const SolidGuiOverlay overlay{64, 64, {0, 0, 128, 128}};
Expand Down Expand Up @@ -416,7 +425,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );
renderer->SetClearColor ( window, 0.0f, 0.0f, 0.0f, 1.0f );
// Premultiplied BGRA: the top half is red, the bottom half fully
Expand Down Expand Up @@ -451,7 +463,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );

Pipeline pipeline;
Expand Down Expand Up @@ -497,7 +512,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );
renderer->SetClearColor ( window, 0.0f, 0.0f, 0.0f, 1.0f );

Expand Down Expand Up @@ -560,8 +578,11 @@ namespace AeonGames
settings.mDirectionalShadowMapResolution = 32;
settings.mSpotShadowMapResolution = 32;
settings.mPointShadowMapResolution = 32;
std::unique_ptr<Renderer> renderer = ConstructRenderer ( std::string {"Metal"}, window, settings );
ASSERT_NE ( renderer, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window, settings );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );
renderer->SetClearColor ( window, 0.0f, 0.25f, 0.5f, 1.0f );

Expand Down Expand Up @@ -623,8 +644,11 @@ namespace AeonGames
ASSERT_NE ( window, nullptr );
RendererSettings settings{};
settings.mDirectionalShadowMapResolution = 32;
std::unique_ptr<Renderer> renderer = ConstructRenderer ( std::string {"Metal"}, window, settings );
ASSERT_NE ( renderer, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window, settings );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );
renderer->SetClearColor ( window, 0.0f, 0.0f, 0.0f, 1.0f );
renderer->SetProjectionMatrix ( window, Matrix4x4{} );
Expand Down Expand Up @@ -705,8 +729,11 @@ namespace AeonGames
settings.mSkyboxEnvironmentFaceSize = 8;
settings.mPrefilteredEnvironmentFaceSize = 8;
settings.mPrefilteredEnvironmentMipCount = 3;
std::unique_ptr<Renderer> renderer = ConstructRenderer ( std::string {"Metal"}, window, settings );
ASSERT_NE ( renderer, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window, settings );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );

std::vector<float> environment_pixels ( 16 * 8 * 3 );
Expand Down Expand Up @@ -748,7 +775,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );
renderer->SetClearColor ( window, 0.0f, 0.0f, 0.0f, 1.0f );
Matrix4x4 projection{};
Expand Down Expand Up @@ -789,7 +819,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );
Matrix4x4 projection{};
projection.Perspective ( 60.0f, 1.0f, 1.0f, 100.0f );
Expand Down Expand Up @@ -833,7 +866,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 64, 64 );
Matrix4x4 projection{};
projection.Perspective ( 60.0f, 1.0f, 1.0f, 100.0f );
Expand Down Expand Up @@ -906,7 +942,10 @@ namespace AeonGames
void* window = CreateHiddenRenderWindow();
ASSERT_NE ( window, nullptr );
std::unique_ptr<Renderer> renderer = TryConstructRenderer ( "Metal", window );
ASSERT_NE ( renderer, nullptr );
if ( renderer == nullptr )
{
GTEST_SKIP() << "Metal renderer unavailable on this host.";
}
renderer->ResizeViewport ( window, 0, 0, 320, 180 );
Scene scene;
const size_t scene_size = GetResourceSize ( "scenes/main.txt" );
Expand Down
Loading