-
Notifications
You must be signed in to change notification settings - Fork 44
feat: support external CardView submission #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PrinceD96
wants to merge
3
commits into
Adyen:develop
Choose a base branch
from
PrinceD96:daniel/external-card-submit
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
android/src/test/java/com/adyenreactnativesdk/component/EmbeddedComponentBusModuleTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Copyright (c) 2026 Adyen N.V. | ||
| * | ||
| * This file is open source and available under the MIT license. See the LICENSE file for more info. | ||
| */ | ||
|
|
||
| package com.adyenreactnativesdk.component | ||
|
|
||
| import com.adyenreactnativesdk.react.ComponentContract | ||
| import com.adyenreactnativesdk.util.messaging.MessageBus | ||
| import org.junit.After | ||
| import org.junit.Test | ||
| import org.mockito.Mockito.mock | ||
| import org.mockito.Mockito.times | ||
| import org.mockito.Mockito.verify | ||
|
|
||
| class EmbeddedComponentBusModuleTest { | ||
| private val messageBus = mock(MessageBus::class.java) | ||
| private val consumer = mock(ComponentContract::class.java) | ||
| private val sut = EmbeddedComponentBusModule(context = null, messageBus) | ||
|
|
||
| @After | ||
| fun tearDown() { | ||
| EmbeddedComponentBusModule.clearConsumers() | ||
| } | ||
|
|
||
| @Test | ||
| fun submitRoutesToRegisteredConsumer() { | ||
| EmbeddedComponentBusModule.register(VIEW_ID, consumer) | ||
|
|
||
| sut.submit(VIEW_ID) | ||
|
|
||
| verify(consumer, times(1)).onSubmit() | ||
| } | ||
|
|
||
| @Test | ||
| fun hideFailureStopsLoadingWithoutUnregisteringConsumer() { | ||
| EmbeddedComponentBusModule.register(VIEW_ID, consumer) | ||
|
|
||
| sut.hide(VIEW_ID, success = false, message = null) | ||
|
|
||
| verify(consumer, times(1)).onStopLoading() | ||
| sut.submit(VIEW_ID) | ||
| verify(consumer, times(1)).onSubmit() | ||
| } | ||
|
|
||
| companion object { | ||
| private const val VIEW_ID = "card-view" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
android/src/test/java/com/adyenreactnativesdk/react/card/CardComponentManagerTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Copyright (c) 2026 Adyen N.V. | ||
| * | ||
| * This file is open source and available under the MIT license. See the LICENSE file for more info. | ||
| */ | ||
|
|
||
| package com.adyenreactnativesdk.react.card | ||
|
|
||
| import android.os.Looper | ||
| import androidx.fragment.app.FragmentActivity | ||
| import com.adyen.checkout.card.CardComponent | ||
| import com.adyenreactnativesdk.util.messaging.MessageBus | ||
| import org.junit.Assert.assertSame | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
| import org.mockito.kotlin.doAnswer | ||
| import org.mockito.kotlin.mock | ||
| import org.mockito.kotlin.whenever | ||
| import org.robolectric.Robolectric | ||
| import org.robolectric.RobolectricTestRunner | ||
| import org.robolectric.Shadows.shadowOf | ||
|
|
||
| @RunWith(RobolectricTestRunner::class) | ||
| class CardComponentManagerTest { | ||
| private val activity = Robolectric.buildActivity(FragmentActivity::class.java).setup().get() | ||
| private val component = mock<CardComponent>() | ||
| private val sut = | ||
| CardComponentManager(activity, mock<MessageBus>()).apply { | ||
| component = this@CardComponentManagerTest.component | ||
| } | ||
|
|
||
| @Test | ||
| fun `submit invokes the card component on the main thread`() { | ||
| var invocationThread: Thread? = null | ||
| doAnswer { | ||
| invocationThread = Thread.currentThread() | ||
| }.whenever(component).submit() | ||
|
|
||
| runFromBackgroundThread(sut::submit) | ||
|
|
||
| assertSame(Looper.getMainLooper().thread, invocationThread) | ||
| } | ||
|
|
||
| @Test | ||
| fun `stop loading invokes the card component on the main thread`() { | ||
| var invocationThread: Thread? = null | ||
| doAnswer { | ||
| invocationThread = Thread.currentThread() | ||
| }.whenever(component).setInteractionBlocked(false) | ||
|
|
||
| runFromBackgroundThread(sut::stopLoading) | ||
|
|
||
| assertSame(Looper.getMainLooper().thread, invocationThread) | ||
| } | ||
|
|
||
| private fun runFromBackgroundThread(action: () -> Unit) { | ||
| Thread(action).apply { | ||
| start() | ||
| join() | ||
| } | ||
| shadowOf(Looper.getMainLooper()).idle() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.