Feature Terminal API regional endpoint configuration - #936
Open
ashwaniarya-adyen wants to merge 6 commits into
Open
Feature Terminal API regional endpoint configuration#936ashwaniarya-adyen wants to merge 6 commits into
ashwaniarya-adyen wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors how the Terminal API region and cloud endpoints are configured in the Adyen PHP client. It introduces a new setTerminalApiRegion method in the Client class, updates PosPayment to utilize this method, and adds comprehensive unit tests to verify the behavior. The review feedback suggests improving code quality and type safety by adding a : void return type declaration, using strict comparisons, and reusing local configuration variables.
ashwaniarya-adyen
changed the title
gcatanese
reviewed
Sep 3, 2026
candemiralp
reviewed
Sep 4, 2026
|
candemiralp
approved these changes
Sep 4, 2026
gcatanese
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Client::setTerminalApiRegion()and ensures the resolved regional endpoint is written toendpointTerminalCloud, which is used by/sync,/async, andterminalApiCloudEndpointfor compatibility, supports valid legacyregionconfiguration, givesterminalApiRegionpriority, and throwsAdyenExceptionfor unsupported regions.Tested scenarios
- Regional Terminal API URLs for sync, async, and connected terminals.
- Region set before or after live environment configuration.
- Default live and test endpoints.
- Invalid regions and legacy
regioncompatibility.PHP Library - Support Region in Terminal API