Skip to content

[configurationwebhooks] Code generation: update services and models - #920

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/configurationwebhooks
Open

[configurationwebhooks] Code generation: update services and models#920
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/configurationwebhooks

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the configurationwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner July 23, 2026 13:27

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new PHP model classes for Configuration Webhooks, specifically handling top-up configurations and events. A review comment identifies an issue in WebhookTopUpTrigger.php where the optional schedule property can be null, but the setSchedule method validates it against enum values without a null check, potentially causing false-positive error logs. A code suggestion is provided to add a null check before validation.

Comment on lines +328 to +336
if (!in_array($schedule, $allowedValues, true)) {
error_log(
sprintf(
"schedule: unexpected enum value '%s' - Supported values are [%s]",
$schedule,
implode(', ', $allowedValues)
)
);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The schedule property is optional, meaning it can be null. However, the setSchedule method does not check if the value is null before validating it against the allowed enum values. This will trigger a false-positive error_log warning when null is passed to clear or initialize the field. Adding a null check prevents these unnecessary log warnings.

        if (!is_null($schedule) && !in_array($schedule, $allowedValues, true)) {
            error_log(
                sprintf(
                    "schedule: unexpected enum value '%s' - Supported values are [%s]",
                    $schedule,
                    implode(', ', $allowedValues)
                )
            );
        }

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch 2 times, most recently from 2909dd5 to d4a3b1a Compare July 31, 2026 12:04
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch 2 times, most recently from a2283b1 to ccadb66 Compare August 4, 2026 17:18
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch 3 times, most recently from 0f20e97 to ed92624 Compare August 21, 2026 14:04
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch 2 times, most recently from 35ac5f4 to 5f72993 Compare August 27, 2026 14:02
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch from 5f72993 to dfb253c Compare September 4, 2026 09:50
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant