[transferwebhooks] Code generation: update services and models - #914
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Transfer Webhooks models by removing deprecated status constants and introducing new models for network reasons and tracing data, specifically NetworkReason, TransferDataTracing, TransferEventTracingData, UKFpsTracingData, and USAchTracingData. Feedback is provided regarding the validation logic in TransferDataTracing and TransferEventTracingData, where fpid and traceNumber are currently unconditionally required. Since these fields are mutually exclusive depending on the tracing type (ukFps vs. usAch), the validation checks should be made conditional to prevent webhook validation failures when one of the fields is null.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| public function listInvalidProperties() | ||
| { | ||
| $invalidProperties = []; | ||
|
|
||
| if ($this->container['fpid'] === null) { | ||
| $invalidProperties[] = "'fpid' can't be null"; | ||
| } | ||
| if ($this->container['type'] === null) { | ||
| $invalidProperties[] = "'type' can't be null"; | ||
| } |
There was a problem hiding this comment.
The TransferDataTracing model represents tracing data for either UK Faster Payments (ukFps) or US ACH (usAch) transfers. Since a transfer can only belong to one of these networks, fpid and traceNumber are mutually exclusive and should not both be unconditionally required. Currently, if either is null, validation fails, which breaks webhook validation. These checks should be made conditional on the type of tracing.
if ($this->container['type'] === 'ukFps' && $this->container['fpid'] === null) {
$invalidProperties[] = "'fpid' can't be null";
}
if ($this->container['type'] === null) {
$invalidProperties[] = "'type' can't be null";
}
if ($this->container['type'] === 'usAch' && $this->container['traceNumber'] === null) {
$invalidProperties[] = "'traceNumber' can't be null";
}| public function listInvalidProperties() | ||
| { | ||
| $invalidProperties = []; | ||
|
|
||
| if ($this->container['fpid'] === null) { | ||
| $invalidProperties[] = "'fpid' can't be null"; | ||
| } | ||
| if ($this->container['type'] === null) { | ||
| $invalidProperties[] = "'type' can't be null"; | ||
| } |
There was a problem hiding this comment.
The TransferEventTracingData model represents tracing data for either UK Faster Payments (ukFps) or US ACH (usAch) transfers. Since a transfer can only belong to one of these networks, fpid and traceNumber are mutually exclusive and should not both be unconditionally required. Currently, if either is null, validation fails, which breaks webhook validation. These checks should be made conditional on the type of tracing.
if ($this->container['type'] === 'ukFps' && $this->container['fpid'] === null) {
$invalidProperties[] = "'fpid' can't be null";
}
if ($this->container['type'] === null) {
$invalidProperties[] = "'type' can't be null";
}
if ($this->container['type'] === 'usAch' && $this->container['traceNumber'] === null) {
$invalidProperties[] = "'traceNumber' can't be null";
}
d9d4b6a to
2918495
Compare
caf4095 to
5ca1668
Compare
a061991 to
70a8a46
Compare
2389c46 to
b26d5c4
Compare
108650e to
50c5518
Compare
f07670d to
cddb82e
Compare
|
SDK Automator not taking care of - |
|
The changes match the OpenAPI update. The tracing models are affected by the PHP generator’s known oneOf limitation, which will be addressed separately and does not regress existing webhook flows. Approving and merging. |
cddb82e to
8542fc4
Compare
|
2 participants
This PR contains the automated changes for the
transferwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.New Features -
Adds network reason details to transfers.
Adds tracing models for UK Faster Payments and US ACH.
Removes the obsolete adviceAuthorised and adviceRefused status values.