Skip to content

[documentcollector] Code generation: update services and models - #2045

Merged
poojah-adyen merged 2 commits into
mainfrom
sdk-automation/documentcollector
Aug 26, 2026
Merged

[documentcollector] Code generation: update services and models#2045
poojah-adyen merged 2 commits into
mainfrom
sdk-automation/documentcollector

Conversation

@AdyenAutomationBot

@AdyenAutomationBot AdyenAutomationBot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the documentcollector service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

New Features 💎

Cross-border Invoices API

  • Add DocumentsApi.uploadCrossBorderInvoice and its RequestOptions overload for multipart PDF uploads to POST /crossBorderInvoices
  • Add DocumentContext.PACBINVOICE, DocumentUploadResponse, DefaultErrorResponseEntity, and InvalidField models.

Other Changes 🖇️

  • Add tests for TEST, LIVE, and custom URLs, multipart parameters, and response deserialization.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner August 21, 2026 14:02

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the auto-generated Java SDK client and models for the Cross-border Invoices API (documentcollector service). While the addition of these models and API endpoints is correct in scope, several critical issues were identified in the generated code. Specifically, the uploadCrossBorderInvoice method in DocumentsApi discards all of its parameters and forwards a null request, making document uploads impossible. Additionally, the static mapper in the JSON class is unsafely initialized inside a non-static constructor, which poses thread-safety risks and should be moved to a static block. Finally, a minor improvement is needed in AbstractOpenApiSchema to add a missing @Override annotation to the equals method.

Comment thread src/main/java/com/adyen/service/documentcollector/DocumentsApi.java
Comment thread src/main/java/com/adyen/model/documentcollector/JSON.java
@gcatanese gcatanese added the Feature Indicates a new feature addition label Aug 24, 2026
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/documentcollector branch from 96851e0 to 0c2e21b Compare August 25, 2026 14:57
@sonarqubecloud

Copy link
Copy Markdown

@gcatanese gcatanese left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!

@poojah-adyen
poojah-adyen added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit 9aa71a3 Aug 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Indicates a new feature addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants